Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove creds-init image from release/nightly pipelines #3674

Merged

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jan 11, 2021

Changes

The creds-init image is no more, so we can remove it from the images
that are built during the release (nightly or official).

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/cc @sbwsg @afrittoli

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

The creds-init image is no more, so we can remove it from the images
that are built during the release (nightly or official).

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester added this to the Pipelines v0.20 milestone Jan 11, 2021
@tekton-robot tekton-robot requested review from afrittoli and a user January 11, 2021 14:38
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
If we wanted at some point to make a v0.19.x or earlier minor release, we may need the old version of the pipeline, but I think this can be solved by pulling the version of the pipeline from the branch.
If future, we might want to keep tagged version of these into a registry, so we can run the correct version just by changing the bundle version.
/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@ghost
Copy link

ghost commented Jan 11, 2021

I am disappointed that my grep-fu did not catch these when I removed the source last week. 😅

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost
Copy link

ghost commented Jan 11, 2021

/test pull-tekton-pipeline-integration-tests

@vdemeester
Copy link
Member Author

tekton-pipelines   2m42s       Warning   InspectFailed                  pod/tekton-pipelines-webhook-5b7cd8c956-7x8v5                        Failed to apply default image tag "ko://github.com/tektoncd/pipeline/cmd/webhook": couldn't parse image reference "ko://github.com/tektoncd/pipeline/cmd/webhook": invalid reference format

Oh... tektoncd/plumbing#675 is really needed 😬

@afrittoli
Copy link
Member

/test pull-tekton-pipeline-integration-tests

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@tekton-robot tekton-robot merged commit f128b41 into tektoncd:master Jan 12, 2021
@vdemeester vdemeester deleted the remove-creds-init-image-from-pipeline branch January 12, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants