Remove tekton.dev/task label from taskrun of clustertasks #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/XS
|
/hold cc @vdemeester @bobcatfish @sbwsg This is regarding the removal of deprecation thing. Let me know if any other changes are required for this |
tekton-robot
added
the
do-not-merge/hold
AlanGreene
suggested changes
Feb 15, 2021
This will remove the label tekton.dev/task label from taskruns which are referencing a clusterTask. This was marked deprecated in v0.12.0 Fix tektoncd#2533
piyush-garg
force-pushed
the
remove_label
branch
from
2d0256f
to
db37457
Compare
piyush-garg
changed the title
@AlanGreene Thanks for this. Mistakes while typing. Fixed these now. |
|
This looks good to me. Suggest also updating |
|
I'll remove the deprecation in a follow-up PR. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
thank you @sbwsg @vdemeester 🙏 |
tekton-robot
removed
the
do-not-merge/hold
vinamra28
added a commit
to vinamra28/cli
that referenced
this pull request
Mar 22, 2021
`tkn clustertask start` command with `--last` flag was checking for the label `tekton.dev/task=name` in the created taskruns since any taskrun created from clustertask had the labels `tekton.dev/clusterTask=name` and `tekton.dev/task=name`. Since pipelines 0.22 release the label `tekton.dev/task=name` has been removed from the taskruns which were created from clustertasks. See: tektoncd/pipeline#3764 Fixing this in pkg/task/tasklastrun.go and adding corresponding tests. Signed-off-by: vinamra28 <vinjain@redhat.com>
4 tasks
vinamra28
added a commit
to vinamra28/cli
that referenced
this pull request
Mar 22, 2021
`tkn clustertask start` command with `--last` flag was checking for the label `tekton.dev/task=name` in the created taskruns since any taskrun created from clustertask had the labels `tekton.dev/clusterTask=name` and `tekton.dev/task=name`. Since pipelines 0.22 release the label `tekton.dev/task=name` has been removed from the taskruns which were created from clustertasks. See: tektoncd/pipeline#3764 Fixing this in pkg/task/tasklastrun.go and adding corresponding tests. Signed-off-by: vinamra28 <vinjain@redhat.com>
vinamra28
added a commit
to vinamra28/cli
that referenced
this pull request
Mar 22, 2021
`tkn clustertask start` command with `--last` flag was checking for the label `tekton.dev/task=name` in the created taskruns since any taskrun created from clustertask had the labels `tekton.dev/clusterTask=name` and `tekton.dev/task=name`. Since pipelines 0.22 release the label `tekton.dev/task=name` has been removed from the taskruns which were created from clustertasks. See: tektoncd/pipeline#3764 Fixing this in pkg/task/tasklastrun.go and adding corresponding tests. Signed-off-by: vinamra28 <vinjain@redhat.com>
tekton-robot
pushed a commit
to tektoncd/cli
that referenced
this pull request
Mar 23, 2021
`tkn clustertask start` command with `--last` flag was checking for the label `tekton.dev/task=name` in the created taskruns since any taskrun created from clustertask had the labels `tekton.dev/clusterTask=name` and `tekton.dev/task=name`. Since pipelines 0.22 release the label `tekton.dev/task=name` has been removed from the taskruns which were created from clustertasks. See: tektoncd/pipeline#3764 Fixing this in pkg/task/tasklastrun.go and adding corresponding tests. Signed-off-by: vinamra28 <vinjain@redhat.com>
piyush-garg
pushed a commit
to tektoncd/cli
that referenced
this pull request
Mar 31, 2021
`tkn clustertask start` command with `--last` flag was checking for the label `tekton.dev/task=name` in the created taskruns since any taskrun created from clustertask had the labels `tekton.dev/clusterTask=name` and `tekton.dev/task=name`. Since pipelines 0.22 release the label `tekton.dev/task=name` has been removed from the taskruns which were created from clustertasks. See: tektoncd/pipeline#3764 Fixing this in pkg/task/tasklastrun.go and adding corresponding tests. Signed-off-by: vinamra28 <vinjain@redhat.com>
piyush-garg
pushed a commit
to tektoncd/cli
that referenced
this pull request
Mar 31, 2021
`tkn clustertask start` command with `--last` flag was checking for the label `tekton.dev/task=name` in the created taskruns since any taskrun created from clustertask had the labels `tekton.dev/clusterTask=name` and `tekton.dev/task=name`. Since pipelines 0.22 release the label `tekton.dev/task=name` has been removed from the taskruns which were created from clustertasks. See: tektoncd/pipeline#3764 Fixing this in pkg/task/tasklastrun.go and adding corresponding tests. Signed-off-by: vinamra28 <vinjain@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the label tekton.dev/task label from taskruns which
are referencing a clusterTask. This was marked deprecated in v0.12.0
Fix #2533
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
For pull requests with a release note: