Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of absolute vs relative path from workspaces doc #3852

Merged
merged 1 commit into from Mar 25, 2021
Merged

Remove mention of absolute vs relative path from workspaces doc #3852

merged 1 commit into from Mar 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 25, 2021

Changes

Fixes #3851

Similarly to commit d80cbc our workspace docs stated that if you provide
a relative path to the workspace's mountPath then it would be appended
to /workspace.

This was never the case and so this commit removes mention of it.

/kind documentation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

Release Notes

Removed incorrect doc that stated workspaces with relative mountPath would be mounted relative to /workspace

Similarly to commit d80cbc our workspace docs stated that if you provide
a relative path to the workspace's `mountPath` then it would be appended
to `/workspace`.

This was never the case and so this commit removes mention of it.
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 25, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2021
@ghost ghost requested a review from tualeron March 25, 2021 10:36
@tualeron
Copy link
Contributor

Looks good.

@jlpettersson
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@pritidesai
Copy link
Member

thanks @sbwsg
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai, sergetron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@tekton-robot tekton-robot merged commit 01a3388 into tektoncd:main Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mountPath can not mount relative path
4 participants