New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConfigMap which can contain pipelines info and RBAC to access this ConfigMap #3971
Conversation
a5e165f
to
2374d1a
Compare
It would be great to include some comments in the ConfigMap and the role / rolebinding giving a short explanation of the purpose. "allow tools to query for the current installed pipelines version without elevated permissions" or something similar, wdyt? |
As of now we fetch version of pipelines through labels present on the deployments which is read by tools such as `tkn cli` and display the version. This version may not be displayed to users if they don't have permission to view the deployment. In this commit we are adding 1. A `ConfigMap` which contains version information. 2. RBAC which will give appropriate permissions to view the ConfigMap irrespective of whether user is has permission to view other objects in that namespace or not. Signed-off-by: vinamra28 <vinjain@redhat.com>
2374d1a
to
6b49b63
Compare
/retest |
/test check-pr-has-kind-label |
looks like check-pr-has-kind-label pipelinerun is passing, but the result is not updated here. cc @afrittoli |
/kind feature |
How will the ConfigMap be updated with the release version? Is the idea that the operator will take care of this or we'll bake it into the |
@sbwsg yeah during the release process the value will get updated with the help of following Line 132 in f911d73
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks good 👍 |
/cc @afrittoli @imjasonh |
/cc @vdemeester |
/lgtm |
/retest |
/retest |
Build tests ran successfully but prow didn't reported it 🤔 |
Changes
As of now we fetch version of pipelines through labels present on the
deployments which is read by tools such as
tkn cli
and display theversion. This version may not be displayed to users if they don't have
permission to view the deployment.
In this commit we are adding
ConfigMap
which contains version information.irrespective of whether user is has permission to view other objects in
that namespace or not.
This is covered as part of TEP-0041
Signed-off-by: vinamra28 vinjain@redhat.com
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes