[cherry-pick] Update tektoncd/plumbing.

[jerop]

Changes

This is pulls in tektoncd/plumbing@3c5af40 to fix integration tests.

(cherry picked from commit 55ae856)

We need to cherry pick this change into v0.24 to run integration tests for a Workspaces in Sidecars fix. We need to fix the Workspaces in Sidecars to be serialized as workspaces not Workspaces. This is change is made in #4008. Its integration tests are failing because basic authentication was removed for GKE cluster versions >= 1.19 so clusters cannot be created with basic authentication enabled. So we need to cherry pick this change to disable basic auth and create clusters to run the tests for the Workspaces in Sidecars fix.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerop]

/test check-pr-has-kind-label

[bobcatfish]

hey @jerop! tiny pedantic request: could you explain a bit more (ideally in the commit message) about why this is needed and how it fixes things? you linked to tektoncd/plumbing@3c5af40 and the explanation there makes this sound like a cleanup that maybe will in the future be relevant

the commit said:

Additionally, this feature is going away in GKE 1.19, so we're better off disabling it ASAP in preparation.

so im guessing the situation might be that we are now using 1.19 so this is a problem? or is it something else?

Thanks!! 🙏

[jerop]

thanks for the reviews!!

@bobcatfish I've added more detail to the commit messages and PR description:

We need to cherry pick this change into v0.24 to run integration tests for a Workspaces in Sidecars fix. We need to fix the Workspaces in Sidecars to be serialized as workspaces not Workspaces. This is change is made in #4008. Its integration tests are failing because basic authentication was removed for GKE cluster versions >= 1.19 so clusters cannot be created with basic authentication enabled. So we need to cherry pick this change to disable basic auth and create clusters to run the tests for the Workspaces in Sidecars fix.

[vdemeester]

hey @jerop! tiny pedantic request: could you explain a bit more (ideally in the commit message) about why this is needed and how it fixes things? you linked to tektoncd/plumbing@3c5af40 and the explanation there makes this sound like a cleanup that maybe will in the future be relevant

the commit said:

Additionally, this feature is going away in GKE 1.19, so we're better off disabling it ASAP in preparation.

so im guessing the situation might be that we are now using 1.19 so this is a problem? or is it something else?

Thanks!!

Note that this is also due to the fact that, the version of k8s we use for a given release is not tied to the release (aka if we were to release 0.10 today, we would run against a 1.19, whereas at the time of the release we were using 1.15 or something).

/lgtm
/meow

[tekton-robot]

@vdemeester:

In response to this:

hey @jerop! tiny pedantic request: could you explain a bit more (ideally in the commit message) about why this is needed and how it fixes things? you linked to tektoncd/plumbing@3c5af40 and the explanation there makes this sound like a cleanup that maybe will in the future be relevant

the commit said:

Additionally, this feature is going away in GKE 1.19, so we're better off disabling it ASAP in preparation.

so im guessing the situation might be that we are now using 1.19 so this is a problem? or is it something else?

Thanks!!

Note that this is also due to the fact that, the version of k8s we use for a given release is not tied to the release (aka if we were to release 0.10 today, we would run against a 1.19, whereas at the time of the release we were using 1.15 or something).

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.