Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update knative/pkg to v0.23 and k8s.io to v0.20.7 #4044

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Update knative/pkg to v0.23 and k8s.io to v0.20.7 #4044

merged 1 commit into from
Jun 29, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jun 16, 2021 •
edited

Changes

Bump k8s.io and knative dependencies to v0.20.7 and v0.23.0 respectively, taking latest fixes and features in.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Bump k8s.io and knative dependencies to v0.20.7 and v0.23.0 respectively, taking latest fixes and features in.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 16, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2021
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2021
@ghost
Copy link

ghost commented Jun 21, 2021

It looks like this has regenerated openapi / swagger specs with new package names (they've dropped the github.com/ prefix).

Otherwise the dep updates look good to me.

@vdemeester
Copy link
Member Author

It looks like this has regenerated openapi / swagger specs with new package names (they've dropped the github.com/ prefix).

Arg, all the time it hits me..

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 23, 2021
@vdemeester vdemeester force-pushed the bump-knative-k8s branch 2 times, most recently from 166a470 to ba88617 Compare June 23, 2021 13:47
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2021
@vdemeester vdemeester force-pushed the bump-knative-k8s branch 2 times, most recently from d54bad5 to f96c404 Compare June 23, 2021 14:32
@vdemeester
Update knative/pkg to v0.23 and k8s.io to v0.20.7
5d1a0b9 
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Copy link
Member Author

/retest

@vdemeester
Copy link
Member Author

/retest
The build job is green but reporting red.. and the other one seems to be a flaky cluster provisionning...

@vdemeester
Copy link
Member Author

/retest

@ghost
Copy link

ghost commented Jun 24, 2021

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
pradeepitm12
pradeepitm12 reviewed Jun 29, 2021
View reviewed changes
Copy link

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

@pradeepitm12: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot
Copy link
Collaborator

@nikhil-thomas: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chmouel
Copy link
Member

chmouel commented Jun 29, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@tekton-robot tekton-robot merged commit 94bb776 into tektoncd:main Jun 29, 2021
@vdemeester vdemeester deleted the bump-knative-k8s branch June 29, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@dibyom dibyom Awaiting requested review from dibyom

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vdemeester @tekton-robot @nikhil-thomas @chmouel @pradeepitm12