Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust weight in hermetic.md #4056

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Adjust weight in hermetic.md #4056

merged 1 commit into from
Jun 24, 2021

Conversation

eliasnorrby
Copy link
Contributor

Hermetic execution is an experimental feature and should not be at the top of the list in the website sidebar navigation.

image

Changes

Adjusts the weight property of hermetic.md from 10 to 1650, bringing it from the top of the website sidebar navigation to a point below core concepts.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [:no_good_man:] Docs included if any changes are user facing
  • [:no_good_man:] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@eliasnorrby
Adjust weight in hermetic.md
4f58f29 
Hermetic execution is an experimental feature and should not be at the
top of the list in the website sidebar navigation.
@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesnt merit a release note. labels Jun 23, 2021
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2021
@tekton-robot
Copy link
Collaborator

Hi @eliasnorrby. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliasnorrby
Copy link
Contributor Author

/assign @jerop

@imjasonh
Copy link
Member

/ok-to-test
/lgtm

Thanks!

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@vdemeester
Copy link
Member

/retest

@ghost
Copy link

ghost commented Jun 23, 2021

/test pull-tekton-pipeline-build-tests

1 similar comment
@ghost
Copy link

ghost commented Jun 23, 2021

/test pull-tekton-pipeline-build-tests

@ghost
Copy link

ghost commented Jun 23, 2021

/test pull-tekton-pipeline-integration-tests

@ghost ghost removed the kind/documentation Categorizes issue or PR as related to documentation. label Jun 23, 2021
@ghost
Copy link

ghost commented Jun 23, 2021

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 23, 2021
@ghost
Copy link

ghost commented Jun 23, 2021

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot merged commit 005c31e into tektoncd:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@imjasonh imjasonh

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eliasnorrby @tekton-robot @imjasonh @vdemeester @jerop