Use knative.dev/pkg/changeset
#4126
Conversation
tekton-robot
added
release-note-none
tekton-robot
added
the
size/M
|
There was a (brief) discussion of this on slack here: https://tektoncd.slack.com/archives/CLCCEBUMU/p1627503258123300 |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
This replaces the need for `./pkg/version` and a flag with the automatic inference of the version of the deployed code from the git metadata symlinked into `kodata/` This package is already used to automatically decorate the zap loggers, and a few other places (iirc). /kind cleanup
tekton-robot
added
size/L
|
The following is the coverage report on the affected files.
|
|
Is the change to controller.yaml going to run afoul of the modification done in Lines 131 to 132 in a728ce3 |
|
Thanks for making my eyes bleed @imjasonh 😉 There's probably an expression in there we no longer need, but I hate touching bash that presubmits don't check. Lemme look closer. |
|
The following is the coverage report on the affected files.
|
|
@imjasonh @vdemeester this should be RFAL. |
|
post-weekend bump 😁 |
|
@mattmoor does it support only a commit hash, or can it show a tag ? |
As it is today, I believe it resolves the tag to a commit, but all the info is in kodata, so we could adapt the changeset package to do more. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/retest |
|
So @mattmoor one downside of this approach is, it fails if the images are not build with The trick is that, if there is no |
| version, err := changeset.Get() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| podAnnotations[ReleaseAnnotation] = version |
There was a problem hiding this comment.
Maybe we should log something and print unknown here instead of erroring out, wdyt @mattmoor ?
Changes
This replaces the need for
./pkg/versionand a flag with the automatic inference of the version of the deployed code from the git metadata symlinked intokodata/This package is already used to automatically decorate the zap loggers, and a few other places (iirc).
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes