Verify failure of PipelineRun
in TestGitPipelineRunFail
#4273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TestGitPipelineRunFail
is test that is meant to verify that code extraction fails with invalid inputs to theGit
PipelineResource
.However, the test does not fail if the
PipelineRun
does not succeed.In this change, we ensure that the
PipelineRun
fails in these circumstances./kind bug
--
Pulled in commit from #3870 by @savitaashture and made updates to it
Pruning old PRs as Build Captain
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes