Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused error type CannotConvertError #4281

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Remove unused error type CannotConvertError #4281

merged 2 commits into from
Oct 13, 2021

Conversation

guillaumerose
Copy link
Contributor

@guillaumerose guillaumerose commented Oct 6, 2021 •
edited
Loading

Changes

First commit is just a run of ./hack/update-deps.sh on my machine. It has unexpected changes. I did it with go1.16.8.

Then, when looking at reducing the visibility of ConvertErrorf to package private, I found out that CannotConvertError was not used. I propose to remove it. Although, I don't know if you consider this as an API breakage 馃檹

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Remove unused error type CannotConvertError

@guillaumerose
Sync third_party directory
7fd991c 
It turns out running ./hack/update-deps.sh with go1.16.8 change some
files in third_party/
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 6, 2021
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2021
@tekton-robot
Copy link
Collaborator

Hi @guillaumerose. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 74.3% 75.4% 1.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 75.9% 77.2% 1.3

vdemeester
vdemeester approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sad we are not using them but at the same time, if we don't use it, let's remove it 馃懠馃徏
/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

I am sad we are not using them but at the same time, if we don't use it, let's remove it 馃懠馃徏
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@guillaumerose
Remove unused types CannotConvertError
10898b6 
CannotConvertError struct is never initialized, it's better to remove
it.

It also unveils that MarkResourceNotConvertible is unused for TaskRun
and PipelineRun.
@guillaumerose
Copy link
Contributor Author

Bad Gateway in a integration test and I messed up with gofmt. Pushing again.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 74.3% 75.4% 1.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 75.9% 77.2% 1.3

@vdemeester
Copy link
Member 

            message: 'failed to create task run pod "step-by-digest-9b2kw": translating TaskSpec
              to Pod: error getting image config: Get "https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/02/020584afccce44678ec82676db80f68d50ea5c766b6e9d9601f7b5fc86dfb96d/data?verify=1633532007-VKnfW1F4DzePbfbtL%2Bgm2jKoUoU%3D":
              read tcp 10.0.0.12:34746->104.18.124.25:443: read: connection reset by peer.

/retest

@pritidesai pritidesai mentioned this pull request Oct 11, 2021
Merged
5 tasks
@ghost
Copy link

ghost commented Oct 12, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Oct 12, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@guillaumerose
Copy link
Contributor Author

Could not resolve host: github.com error in integration tests.

/retest

@ghost
Copy link

ghost commented Oct 12, 2021

/test pull-tekton-pipeline-alpha-integration-tests

@pritidesai
Copy link
Member

thank you @guillaumerose for your contributions 馃檹

/test pull-tekton-pipeline-alpha-integration-tests

@pritidesai
Copy link
Member 

        error building image: error building stage: failed to get filesystem from image: unexpected EOF

one more attempt 馃

/test pull-tekton-pipeline-alpha-integration-tests

@pritidesai pritidesai mentioned this pull request Oct 12, 2021
Merged
4 tasks
@vdemeester
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit f7d7750 into tektoncd:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guillaumerose @tekton-robot @vdemeester @pritidesai