Explicitly annotate TaskRuns with release version. #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/XS
Previously we were expecting TaskRuns to be decorated with an annotation specifying the release version of the tekton controller, however, the place that was populating these annotations was extremely subtle and fragile. The annotation was set as part of synthesizing the `Pod` to create where the Pod's annotations were based on the `TaskRun`'s. This contains two main changes: 1. Explicitly copy the `TaskRun`'s annotations when populating the pod's annotations to eliminate this implicit and fragile back-propagation of annotations. 2. Add an explicit decoration of the annotation, which is less fragile and executed regardless of whether the Pod is being created during this reconciliation pass. Fixes: tektoncd#4421
mattmoor
force-pushed
the
release-annotation
branch
from
52c3734
to
3ccd2a9
Compare
tekton-robot
added
size/S
mattmoor
changed the title
taskRun.Annotations before alterring them.
tekton-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
|
/test check-pr-has-kind-label |
|
Hmm, looks unrelated: /retest |
|
More timeouts, but in unrelated tests... /retest |
dlorenc
approved these changes
Dec 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
concaf
added a commit
to concaf/pipeline
that referenced
this pull request
Sep 7, 2022
concaf
added a commit
to openshift/tektoncd-pipeline
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were expecting TaskRuns to be decorated with an annotation specifying
the release version of the tekton controller, however, the place that was populating
these annotations was extremely subtle and fragile. The annotation was set as part
of synthesizing the
Podto create where the Pod's annotations were based on theTaskRun's.This contains two main changes:
Explicitly copy the
TaskRun's annotations when populating the pod's annotationsto eliminate this implicit and fragile back-propagation of annotations.
Add an explicit decoration of the annotation, which is less fragile and executed
regardless of whether the Pod is being created during this reconciliation pass.
Fixes: #4421
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes