Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up latest knative.dev/pkg (k8s 0.22 libs) #4449

Merged
merged 1 commit into from Jan 5, 2022
Merged

Pick up latest knative.dev/pkg (k8s 0.22 libs) #4449

merged 1 commit into from Jan 5, 2022

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Jan 4, 2022 •
edited

This change picks up the latest knative.dev/pkg which contains some codegen changes necessary to use Tekton with the K8s 0.22 libraries, which we've seen a handful of requests for.

As part of this, I have dropped the patch Tekton was carrying to add the subresource field. cc @vdemeester

Once this has landed, I will update triggers and chains.

The minimum kubernetes version is still 1.20, so this should NOT be a change to that: https://github.com/knative/pkg/blob/52e42b760b543424fcabcef884cb41e0cc2ff956/version/version.go#L36

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

The pipelines clients are now compatible with k8s.io/client-go v0.22.x

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2022
mattmoor
mattmoor commented Jan 4, 2022
View reviewed changes
hack/spec-gen/main.go
"k8s.io/klog"
"k8s.io/kube-openapi/pkg/common"
spec "k8s.io/kube-openapi/pkg/validation/spec"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing K8s forked this as I had to make this change to get things to pass locally.

@mattmoor
Copy link
Member Author

mattmoor commented Jan 4, 2022

Hmm, I forgot to remove all of the Go 1.16 //go:build nonsense, so let's see if CI was upgraded, or I'm going to have to do a lot of manual editing in nano 🤞

@mattmoor
Copy link
Member Author

mattmoor commented Jan 4, 2022

cc @wlynch who was asking for this

@mattmoor
Copy link
Member Author

mattmoor commented Jan 4, 2022

I think I stripped the right build tags 🤞

@mattmoor
Copy link
Member Author

mattmoor commented Jan 4, 2022

weird. one complains with it and the other complains without it 🙃

@mattmoor
Pick up latest knative.dev/pkg (k8s 0.22 libs)
a912179 
This change picks up the latest `knative.dev/pkg` which contains some codegen changes necessary to use Tekton with the K8s 0.22 libraries, which we've seen a handful of requests for.

Once this has landed, I will update triggers and chains.
@mattmoor
Copy link
Member Author

mattmoor commented Jan 4, 2022

Finally. It looks like most of the codegen gets the new build tags, but the openapi file explicitly must not 🙃

@dlorenc
Copy link
Contributor

dlorenc commented Jan 4, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@imjasonh
Copy link
Member

imjasonh commented Jan 5, 2022

/assign

imjasonh
imjasonh reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@tekton-robot tekton-robot merged commit 3e13764 into tektoncd:main Jan 5, 2022
@mattmoor mattmoor deleted the k8s-22 branch January 5, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh left review comments

@dibyom dibyom Awaiting requested review from dibyom

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattmoor @dlorenc @tekton-robot @imjasonh