cleanup - refactor taskRunStatus and runStatus unit tests #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XL
62 tasks
|
The following is the coverage report on the affected files.
|
pipelinerun_test.go has these three tests: * TestUpdateTaskRunsState * TestUpdateRunsState * TestUpdateTaskRunStateWithConditionChecks These tests are validating func (state PipelineRunState) GetTaskRunsStatus() which is part of the pipelinerunstate.go. Moving these tests to pipelinerunstate_test.go after replacing task/run/pipeline/pipelinerun initializations with YAMLParser.
pritidesai
force-pushed
the
issue-4610-status
branch
from
c91f169
to
27bc62e
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
vdemeester
approved these changes
Mar 8, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
jerop
reviewed
Mar 8, 2022
There was a problem hiding this comment.
TestSidecarTaskSupport is a known flake: #2656
/test pull-tekton-pipeline-integration-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pipelinerun_test.gohas these three tests:These tests are validating func
(state PipelineRunState) GetTaskRunsStatus()which is part of thepipelinerunstate.go. Moving these tests topipelinerunstate_test.goafter replacing task/run/pipeline/pipelinerun initializations with YAMLParser./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes