Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor reconcile pipeline TaskSpecMetadata test #4693

Merged
merged 1 commit into from
Mar 18, 2022
Merged

refactor reconcile pipeline TaskSpecMetadata test #4693

merged 1 commit into from
Mar 18, 2022

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Mar 18, 2022 •
edited

Changes

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

refactor test to parse yaml for Pipeline and PipelineRun for
TestReconcilePipeline_TaskSpecMetadata test

continued work on #4610

Signed-off-by: jbpratt jbpratt78@gmail.com

@jbpratt
refactor reconcile pipeline TaskSpecMetadata test
37324d9 
refactor test to parse yaml for Pipeline and PipelineRun

Signed-off-by: jbpratt <jbpratt78@gmail.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 18, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2022
@tekton-robot
Copy link
Collaborator

Hi @jbpratt. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 18, 2022
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@jbpratt
Copy link
Contributor Author

jbpratt commented Mar 18, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@jbpratt
Copy link
Contributor Author

jbpratt commented Mar 18, 2022 •
edited

😕 i don't think this is related to the changes

@jbpratt
Copy link
Contributor Author

jbpratt commented Mar 18, 2022

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop
Copy link
Member

jerop commented Mar 18, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
@tekton-robot tekton-robot merged commit 80b6d27 into tektoncd:main Mar 18, 2022
@jbpratt jbpratt deleted the test-reconcile-pipelinerun-taskmetadata-refactor branch March 18, 2022 17:21
@talife talife mentioned this pull request Dec 2, 2022
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop jerop approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbpratt @tekton-robot @vdemeester @jerop