Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set explicit parallelism for e2e tests, increase Kaniko e2e test timeouts #4871

Merged
merged 1 commit into from May 17, 2022
Merged

Set explicit parallelism for e2e tests, increase Kaniko e2e test timeouts #4871

merged 1 commit into from May 17, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented May 13, 2022 •
edited

Changes

fixes #4863

The parallelism change appears to make a real difference in cutting down on flaky
tests, while only increasing total duration of the integration test runs to ~30-35
minutes from ~25, which seems like a worthy trade to me.

Also bumps the timeout for Kaniko tasks in e2e tests to 5 minutes, where a timeout
was specified in the first place.

/kind flake

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flakey test release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 13, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2022
@abayer abayer force-pushed the try-decreased-parallelism-of-yaml-tests branch from b15d36c to da27187 Compare May 13, 2022 17:20
@abayer
Copy link
Contributor Author

abayer commented May 13, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 13, 2022

/retest

@abayer
Copy link
Contributor Author

abayer commented May 13, 2022

/test pull-tekton-pipeline-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 13, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 13, 2022

/test pull-tekton-pipeline-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 13, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

2 similar comments
@abayer
Copy link
Contributor Author

abayer commented May 14, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 14, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 14, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@abayer
Copy link
Contributor Author

abayer commented May 14, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

3 similar comments
@abayer
Copy link
Contributor Author

abayer commented May 14, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 14, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

@abayer
Copy link
Contributor Author

abayer commented May 17, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

@abayer
Set explicit parallelism for e2e tests, increase Kaniko e2e test time…
895582f 
…outs

fixes tektoncd#4863

The parallelism change appears to make a real difference in cutting down on flaky
tests, while only increasing total duration of the integration test runs to ~30-35
minutes from ~25, which seems like a worthy trade to me.

Also bumps the timeout for Kaniko tasks in e2e tests to 5 minutes, where a timeout
was specified in the first place.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer force-pushed the try-decreased-parallelism-of-yaml-tests branch from da27187 to 895582f Compare May 17, 2022 15:16
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 17, 2022
@abayer abayer changed the title WIP: Try decreasing parallelism of YAML tests Set explicit parallelism for e2e tests, increase Kaniko e2e test timeouts May 17, 2022
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@abayer
Copy link
Contributor Author

abayer commented May 17, 2022

/assign @imjasonh
/assign @mattmoor

@abayer abayer mentioned this pull request May 17, 2022
Open
@imjasonh
Copy link
Member

/lgtm

Thanks!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2022
@tekton-robot tekton-robot merged commit 0c008a0 into tektoncd:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@imjasonh imjasonh

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flakey test lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise the kaniko tests timeout from 2m
5 participants
@abayer @tekton-robot @imjasonh @vdemeester @mattmoor