Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for failing remote resolution of Pipelines and Tasks #4886

Merged
merged 1 commit into from Jun 15, 2022
Merged

Add tests for failing remote resolution of Pipelines and Tasks #4886

merged 1 commit into from Jun 15, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented May 18, 2022

Changes

Prompted by discussion on #4710, though I should have thought of this earlier!

This can't verify that the ResolutionRequest is handled correctly by its own reconciler, since
that's still in a separate project (for now!), but at least we can be sure that the PipelineRun
and TaskRun reconcilers will respond correctly to a failed ResolutionRequest.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@abayer
Add tests for failing remote resolution of Pipelines and Tasks
a0fca7c 
Prompted by discussion on tektoncd#4710, though I should have thought of this earlier!

This can't verify that the `ResolutionRequest` is handled correctly by its own reconciler, since
that's still in a separate project (for now!), but at least we can be sure that the `PipelineRun`
and `TaskRun` reconcilers will respond correctly to a failed `ResolutionRequest`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels May 18, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2022
@abayer
Copy link
Contributor Author

abayer commented May 18, 2022

/assign @vdemeester
/assign @lbernick
/assign @chitrangpatel

@tekton-robot
Copy link
Collaborator

@abayer: GitHub didn't allow me to assign the following users: chitrangpatel.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @vdemeester
/assign @lbernick
/assign @chitrangpatel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
jerop
jerop approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @abayer!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit dffc5ab into tektoncd:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop jerop approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@vdemeester vdemeester

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abayer @tekton-robot @vdemeester @jerop @lbernick