Add conversion for v1 TaskRun #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
size/L
JeromeJu
force-pushed
the
4985-conversion
branch
from
cae4cef
to
73403aa
Compare
tekton-robot
added
release-note-none
JeromeJu
force-pushed
the
4985-conversion
branch
from
73403aa
to
9018265
Compare
tekton-robot
added
the
needs-rebase
JeromeJu
force-pushed
the
4985-conversion
branch
from
9018265
to
d36a9cb
Compare
tekton-robot
removed
the
needs-rebase
tekton-robot
removed
the
do-not-merge/work-in-progress
lbernick
approved these changes
Aug 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
JeromeJu
force-pushed
the
4985-conversion
branch
2 times, most recently
from
7912a58
to
97c6b5e
Compare
tekton-robot
added
size/XL
JeromeJu
force-pushed
the
4985-conversion
branch
from
97c6b5e
to
967f1ac
Compare
|
The following is the coverage report on the affected files.
|
JeromeJu
force-pushed
the
4985-conversion
branch
from
967f1ac
to
af40cf9
Compare
|
The following is the coverage report on the affected files.
|
This commit adds conversion functions between v1beta1 and v1 TaskRun. It does not handle fields deprecated in v1beta1 that will not be present in v1. It implements ConvertTo and ConvertFrom for v1beta1 TaskRun, and leaves these functions unimplemented for v1 TaskRun, since it is the highest known version.
JeromeJu
force-pushed
the
4985-conversion
branch
from
af40cf9
to
1c976a3
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds conversion functions between v1beta1 and v1 TaskRun.
It does not handle fields deprecated in v1beta1 that will not be present in v1.
It implements ConvertTo and ConvertFrom for v1beta1 TaskRun, and leaves
these functions unimplemented for v1 TaskRun, since it is the highest known version.
needs #5272 #5354
Part of #4985
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes