Hygiene: enable `errorlint`. #6340

bendory · 2023-03-09T21:06:31Z

There are no expected functional changes in this PR.

Made non-functional code changes to adhere to Golang error standards.

Added // nolint pragmas in 4 files that violate existing Golang error conventions; @Yongxuanzhang is fixing those issues separately.

Context: #5899

See related style docs:

/kind cleanup

[N/A] Has Docs included if any changes are user facing
[N/A] Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

NONE

bendory · 2023-03-09T21:12:12Z

/unhold

tekton-robot · 2023-03-09T21:13:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-09T21:16:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	84.4%	82.8%	-1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-09T21:18:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

Yongxuanzhang · 2023-03-09T22:09:36Z

Thanks! I think I have a fix for those violations, it can pass the linter check. I can open a PR once this is merged.

bendory · 2023-03-09T23:10:08Z

Thanks! I think I have a fix for those violations, it can pass the linter check. I can open a PR once this is merged.

Great!

bendory · 2023-03-09T23:10:49Z

/retest-required

tekton-robot · 2023-03-09T23:23:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-09T23:25:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-10T13:28:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-10T13:29:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T12:13:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T12:14:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T21:04:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T21:05:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T20:32:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T20:33:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T20:42:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T20:43:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

bendory · 2023-03-29T02:00:21Z

/unhold

tekton-robot · 2023-03-29T02:06:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	83.3%	85.2%	1.9
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-29T02:20:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	83.3%	85.2%	1.9
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

cmd/entrypoint/subcommands/subcommands_test.go

tekton-robot · 2023-03-29T22:21:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-29T22:22:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

There are no expected functional changes in this PR. Made non-functional code changes to adhere to Golang error standards. Context: #5899 See related style docs: - https://pkg.go.dev/errors - https://go.dev/blog/errors-are-values /kind cleanup - [N/A] Has [Docs](https://github.com/tektoncd/community/blob/main/standards.md#docs) included if any changes are user facing - [N/A] Has [Tests](https://github.com/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed - [x] Follows the [commit message standard](https://github.com/tektoncd/community/blob/main/standards.md#commits) - [x] Meets the [Tekton contributor standards](https://github.com/tektoncd/community/blob/main/standards.md) (including functionality, content, code) - [x] Has a kind label. You can add one by adding a comment on this PR that contains `/kind <type>`. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings) - [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release ```release-note NONE ```

tekton-robot · 2023-03-30T17:06:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-30T17:07:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

wlynch

/lgtm

cmd/entrypoint/subcommands/subcommands_test.go

tekton-robot · 2023-03-30T20:01:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from afrittoli, imjasonh and wlynch March 9, 2023 21:06

bendory mentioned this pull request Mar 9, 2023

Cleanup: uplevel our technical hygiene by enabling additional Golang linters #5899

Closed

39 tasks

bendory force-pushed the e2 branch from 8711d5c to 75a36d6 Compare March 9, 2023 21:10

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2023

bendory force-pushed the e2 branch from 75a36d6 to b8b3c89 Compare March 9, 2023 23:18

bendory force-pushed the e2 branch from b8b3c89 to bec082a Compare March 10, 2023 13:21

bendory force-pushed the e2 branch from bec082a to 507966d Compare March 14, 2023 12:08

bendory force-pushed the e2 branch from 507966d to f6a35a6 Compare March 14, 2023 20:57

bendory force-pushed the e2 branch from f6a35a6 to 7ed4140 Compare March 16, 2023 17:59

bendory force-pushed the e2 branch 2 times, most recently from 0c397dd to b22746a Compare March 28, 2023 20:25

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023

bendory force-pushed the e2 branch from b22746a to 7a3c76b Compare March 28, 2023 20:36

bendory force-pushed the e2 branch from 7a3c76b to 5fef8af Compare March 29, 2023 02:00

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2023

bendory requested review from wlynch and removed request for imjasonh and afrittoli March 29, 2023 02:55

wlynch reviewed Mar 29, 2023

View reviewed changes

cmd/entrypoint/subcommands/subcommands_test.go Show resolved Hide resolved

bendory force-pushed the e2 branch from 5fef8af to 4afac59 Compare March 29, 2023 22:15

bendory force-pushed the e2 branch from 4afac59 to c54cbbb Compare March 30, 2023 17:00

wlynch approved these changes Mar 30, 2023

View reviewed changes

cmd/entrypoint/subcommands/subcommands_test.go Show resolved Hide resolved

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023

tekton-robot merged commit d3f8f3a into tektoncd:main Mar 30, 2023

bendory deleted the e2 branch March 30, 2023 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hygiene: enable `errorlint`. #6340

Hygiene: enable `errorlint`. #6340

bendory commented Mar 9, 2023 •

edited

bendory commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

Yongxuanzhang commented Mar 9, 2023

bendory commented Mar 9, 2023

bendory commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

bendory commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 30, 2023

tekton-robot commented Mar 30, 2023

wlynch left a comment

tekton-robot commented Mar 30, 2023

Hygiene: enable errorlint. #6340

Hygiene: enable errorlint. #6340

Conversation

bendory commented Mar 9, 2023 • edited

bendory commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

Yongxuanzhang commented Mar 9, 2023

bendory commented Mar 9, 2023

bendory commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

bendory commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 30, 2023

tekton-robot commented Mar 30, 2023

wlynch left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 30, 2023

Hygiene: enable `errorlint`. #6340

Hygiene: enable `errorlint`. #6340

bendory commented Mar 9, 2023 •

edited