Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PipelineResourceResult to RunResult #6434

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Rename PipelineResourceResult to RunResult #6434

merged 1 commit into from
Apr 4, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Mar 27, 2023 •
edited
Loading

Changes

This commit renames PipelineResourceResult Golang struct to PipelineInternalResult. No functional changes.

A followup PR for #6434 will move the renamed struct to a proper space since resource_types is no longer used after the removal of all PipelineResources.

part of #6197
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Mar 27, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 27, 2023
@JeromeJu JeromeJu mentioned this pull request Mar 27, 2023
Closed
4 tasks
@JeromeJu JeromeJu marked this pull request as draft March 27, 2023 13:00
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2023
@JeromeJu JeromeJu force-pushed the rename-pipelineresource-result branch 2 times, most recently from b2ef1cc to bedaa5c Compare March 27, 2023 16:08
@JeromeJu JeromeJu marked this pull request as ready for review March 27, 2023 16:15
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2023
@JeromeJu JeromeJu mentioned this pull request Mar 27, 2023
Merged
6 tasks
@JeromeJu JeromeJu force-pushed the rename-pipelineresource-result branch from e80267a to 7f700e5 Compare March 28, 2023 11:59
JeromeJu
JeromeJu commented Mar 28, 2023
View reviewed changes
pkg/apis/pipeline/v1/openapi_generated.go Outdated
@@ -30,68 +30,68 @@ import (

func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenAPIDefinition {
return map[string]common.OpenAPIDefinition{
"github.com/tektoncd/pipeline/pkg/apis/pipeline/pod.AffinityAssistantTemplate": schema_pkg_apis_pipeline_pod_AffinityAssistantTemplate(ref),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I am confused by how ./hack.update-codegen has behaved on my local env of m1 macOS, I have put the tekton/pipeline repo under $GOPATH but this seems to be very wrong of changing schema_pkg_apis ref to local 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the "recommended" approach is but I don't set GOPATH, and the scripts should set up a temporary GOPATH for codegen. Try clearing that env var, running codegen again, and if it's still not working for you, you can open an issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have tried unsetting the env variable. But it sill swapped all github paths to my local paths and caused the diff issue. I opened issue to track at #6485

lbernick
lbernick approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Jerome! Please update the PR title

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@JeromeJu JeromeJu changed the title Rename PipelineResourceResult to PipelineInternalResult Rename PipelineResourceResult to RunResult Mar 28, 2023
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2023
@JeromeJu JeromeJu force-pushed the rename-pipelineresource-result branch from 7f700e5 to 83d9e42 Compare April 3, 2023 17:03
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2023
@JeromeJu JeromeJu force-pushed the rename-pipelineresource-result branch from 83d9e42 to 6080f65 Compare April 4, 2023 15:18
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 4, 2023
@JeromeJu JeromeJu force-pushed the rename-pipelineresource-result branch 2 times, most recently from fa34ad6 to 758b16a Compare April 4, 2023 16:27
@JeromeJu
Rename PipelineResourceResult to RunResult
87b92d5 
This commit renames PipelineResourceResult Golang struct to RunResult. No functional changes.
@JeromeJu JeromeJu force-pushed the rename-pipelineresource-result branch from 758b16a to 87b92d5 Compare April 4, 2023 16:27
@jerop jerop added this to the Pipelines v0.47 milestone Apr 4, 2023
@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@tekton-robot tekton-robot merged commit 54c9b51 into tektoncd:main Apr 4, 2023
@JeromeJu JeromeJu mentioned this pull request Apr 10, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@lbernick lbernick lbernick approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.47
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JeromeJu @tekton-robot @Yongxuanzhang @dibyom @lbernick @jerop