Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-114] Remove the feature flag custom-task-version to stop supporting v1alpha1 Run #6499

Merged
merged 1 commit into from
Apr 6, 2023
Merged

[TEP-114] Remove the feature flag custom-task-version to stop supporting v1alpha1 Run #6499

merged 1 commit into from
Apr 6, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Apr 5, 2023 •
edited
Loading

Changes

This commit closes #5837. It removes the feature flag custom-task-version to stop supporting v1alpha1.Run as planed in TEP-114. There will be a separate PR to remove the v1alpha1.Run tracking by #6498.

/kind feature

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: Feature flag custom-task-version is removed, tekton pipeline will stop supporting v1alpha1 Run and only use v1beta1 CustomRun.

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 5, 2023
@Yongxuanzhang
Copy link
Member Author

/test all

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@Yongxuanzhang Yongxuanzhang force-pushed the remove-custom-task-version branch 2 times, most recently from f6a89c9 to 1915220 Compare April 5, 2023 18:51
@Yongxuanzhang
Copy link
Member Author

/test all

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 5, 2023
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review April 5, 2023 19:25
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2023
@Yongxuanzhang
Copy link
Member Author

/assign @jerop

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@Yongxuanzhang
Copy link
Member Author

/retest

@lbernick lbernick added this to the Pipelines v0.47 milestone Apr 6, 2023
jerop
jerop approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Yongxuanzhang!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
lbernick
lbernick reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to remove the alpha custom task controller? or would that be in the follow-up PR removing v1alpha1 custom task? https://github.com/tektoncd/pipeline/tree/main/test/custom-task-ctrls/wait-task-alpha

docs/pipelines.md Outdated
@@ -1618,7 +1618,8 @@ no `runAfter` can be specified in `finally` tasks.

## Using Custom Tasks

Custom Tasks have been promoted from `v1alpha1` to `v1beta1`. Starting from `v0.43.0`, Pipeline Controller is able to create either `v1alpha1` or `v1beta1` Custom Task gated by a feature flag `custom-task-version`, defaulting to `v1beta1`. You can set `custom-task-version` to `v1alpha1` or `v1beta1` to control which version to create.
Custom Tasks have been promoted from `v1alpha1` to `v1beta1`. Starting from `v0.43.0` to `v0.46.0`, Pipeline Controller is able to create either `v1alpha1` or `v1beta1` Custom Task gated by a feature flag `custom-task-version`, defaulting to `v1beta1`. You can set `custom-task-version` to `v1alpha1` or `v1beta1` to control which version to create.
Starting from `v0.47.0`, feature flag `custom-task-version` is removed and only `v1beta1` Custom Task will be supported.

We'll remove the flag `custom-task-version` and the entire alpha Custom Task in release v0.47.0 (tracked in the issue #5837). See the [migration doc](migrating-v1alpha1.Run-to-v1beta1.CustomRun.md) for details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence needs an update

@Yongxuanzhang
Copy link
Member Author

do we also need to remove the alpha custom task controller? or would that be in the follow-up PR removing v1alpha1 custom task? https://github.com/tektoncd/pipeline/tree/main/test/custom-task-ctrls/wait-task-alpha

Yes I will remove it in next PR.

@Yongxuanzhang
[TEP-114] Remove the feature flag custom-task-version
f42207b 
This commit closes tektoncd#5837. It removes the feature flag
custom-task-version to stop supporting v1alpha1.Run as planed in
TEP-114. There will be a separate PR to remove the v1alpha1.Run tracking
by tektoncd#6498.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang
Copy link
Member Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 6, 2023
@tekton-robot
Copy link
Collaborator

@Yongxuanzhang: The label(s) kind/cancel cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yongxuanzhang
Copy link
Member Author

/remove-kind feature

@tekton-robot tekton-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Apr 6, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 92.7% -0.6
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 89.4% 0.6

@lbernick
Copy link
Member

lbernick commented Apr 6, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@tekton-robot tekton-robot merged commit a12d861 into tektoncd:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

@vdemeester vdemeester Awaiting requested review from vdemeester

@dibyom dibyom Awaiting requested review from dibyom

@imjasonh imjasonh Awaiting requested review from imjasonh

@lbernick lbernick Awaiting requested review from lbernick

Assignees

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.47
Development

Successfully merging this pull request may close these issues.

TEP-0114: Remove the feature flag custom-task-version in release v0.47.0
4 participants
@Yongxuanzhang @tekton-robot @lbernick @jerop