Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6483-Step1: move validation code out of pipeline_types.go #6526

Merged
merged 1 commit into from
Apr 17, 2023
Merged

6483-Step1: move validation code out of pipeline_types.go #6526

merged 1 commit into from
Apr 17, 2023

Conversation

chuangw6
Copy link
Member

@chuangw6 chuangw6 commented Apr 12, 2023 •
edited
Loading

Changes

/kind cleanup

As part of the step 1 of #6483, this commit moves validation functions from pipeline_types.go to pipeline_validation.go

No impact on the downstream consumers b/c they stay in the same package.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep

Release Notes

NONE

@chuangw6
6483-Step1: move validation code out of pipeline_types.go
c628231 
As part of the step 1 of tektoncd#6483,
this commit moves validation function from pipeline_types.go to pipeline_validation.go

No impact on the downstream consumers b/c they stay in the same package.

Signed-off-by: Chuang Wang <chuangw@google.com>
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels Apr 12, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 12, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.1% 85.2% -11.9
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.4% 0.4
pkg/apis/pipeline/v1beta1/pipeline_types.go 95.9% 82.1% -13.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.1% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.1% 85.2% -11.9
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.4% 0.4
pkg/apis/pipeline/v1beta1/pipeline_types.go 95.9% 82.1% -13.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.1% 0.1

@chuangw6
Copy link
Member Author

cc @dibyom @wlynch @pritidesai

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@JeromeJu
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023
@chuangw6
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 968b1d8 into tektoncd:main Apr 17, 2023
@tekton-robot
Copy link
Collaborator

@JeromeJu: #6526 failed to apply on top of branch "release-v0.44.x":

Applying: 6483-Step1: move validation code out of pipeline_types.go
Using index info to reconstruct a base tree...
M	pkg/apis/pipeline/v1/pipeline_types.go
M	pkg/apis/pipeline/v1/pipeline_validation.go
M	pkg/apis/pipeline/v1beta1/pipeline_types.go
M	pkg/apis/pipeline/v1beta1/pipeline_validation.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_validation.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_types.go
Auto-merging pkg/apis/pipeline/v1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1/pipeline_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 6483-Step1: move validation code out of pipeline_types.go
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.44.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu
Copy link
Member

/cherry-pick release-v0.44.x

@JeromeJu: #6526 failed to apply on top of branch "release-v0.44.x":

Applying: 6483-Step1: move validation code out of pipeline_types.go
Using index info to reconstruct a base tree...
M	pkg/apis/pipeline/v1/pipeline_types.go
M	pkg/apis/pipeline/v1/pipeline_validation.go
M	pkg/apis/pipeline/v1beta1/pipeline_types.go
M	pkg/apis/pipeline/v1beta1/pipeline_validation.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_validation.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_types.go
Auto-merging pkg/apis/pipeline/v1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1/pipeline_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 6483-Step1: move validation code out of pipeline_types.go
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

sorry wrong paste while loading under vpn connection

@tekton-robot
Copy link
Collaborator

@JeromeJu: #6526 failed to apply on top of branch "release-v0.44.x":

Applying: 6483-Step1: move validation code out of pipeline_types.go
Using index info to reconstruct a base tree...
M	pkg/apis/pipeline/v1/pipeline_types.go
M	pkg/apis/pipeline/v1/pipeline_validation.go
M	pkg/apis/pipeline/v1beta1/pipeline_types.go
M	pkg/apis/pipeline/v1beta1/pipeline_validation.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_validation.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_types.go
Auto-merging pkg/apis/pipeline/v1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1/pipeline_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 6483-Step1: move validation code out of pipeline_types.go
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.44.x

@JeromeJu: #6526 failed to apply on top of branch "release-v0.44.x":

Applying: 6483-Step1: move validation code out of pipeline_types.go
Using index info to reconstruct a base tree...
M	pkg/apis/pipeline/v1/pipeline_types.go
M	pkg/apis/pipeline/v1/pipeline_validation.go
M	pkg/apis/pipeline/v1beta1/pipeline_types.go
M	pkg/apis/pipeline/v1beta1/pipeline_validation.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_validation.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1beta1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1beta1/pipeline_types.go
Auto-merging pkg/apis/pipeline/v1/pipeline_validation.go
Auto-merging pkg/apis/pipeline/v1/pipeline_types.go
CONFLICT (content): Merge conflict in pkg/apis/pipeline/v1/pipeline_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 6483-Step1: move validation code out of pipeline_types.go
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

sorry wrong paste while loading under vpn connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom dibyom approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chuangw6 @tekton-robot @JeromeJu @vdemeester @dibyom