Don't mark done PipelineRuns as timed out

[SaschaSchwarze0]

Changes

This PR fixes a bug that causes all completed PipelineRuns to eventually go into PipelineRunTimeout status. This was imo introduced by Fix for PipelineRuns getting stuck in the running state in the cluster #6095 in v0.47.0 @RafaeLeal @lbernick @jerop

To reproduce the issue, perform these three steps:

(1) Create a simple Pipeline

apiVersion: tekton.dev/v1
kind: Pipeline
metadata:
  name: noop
spec:
  tasks:
    - name: noop
      taskSpec:
        steps:
          - name: noop
            image: busybox
            command:
              - sleep
            args:
              - "1"
      timeout: 1m

(2) Create a simple PipelineRun

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  generateName: noop-
spec:
  pipelineRef:
    name: noop
  timeouts:
    pipeline: 1m

(3) The PipelineRun will complete successfully within a few seconds. Now wait three minutes.

(4) Restart the tekton-pipelines-controller. This will cause all PipelineRuns in the system to get reconciled.

And now the PipelineRun is moved into PipelineRunTimeout status.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

/kind bug

Release Notes

Completed PipelineRuns are not anymore changed to PipelineRunTimeout status

[tekton-robot]

Hi @SaschaSchwarze0. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wlynch]

/uncc @wlynch
/cc @lbernick @jerop

[lbernick]

Thank you @SaschaSchwarze0! We'll have to backport this.
/ok-to-test
/cherrypick release-v0.47.x

[jerop]

/need-cherry-pick

[jerop]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jerop,lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerop]

/retest

[jerop]

/test pull-tekton-pipeline-go-coverage

[lbernick]

/cherry-pick release-v0.47.x

[tekton-robot]

@lbernick: new pull request created: #6634

In response to this:

/cherry-pick release-v0.47.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.