[TEP-0142] Refactor extractStepActions #7328

Yongxuanzhang · 2023-11-02T20:26:52Z

Changes

This commit moves extractStepActions to a dedicated function called in Taskrun Reconciler, this can help the work for remote resolution of StepAction and also decouple the functions.

This PR is a split from #7321

/kind cleanup

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2023-11-02T20:26:54Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Yongxuanzhang · 2023-11-02T20:27:11Z

/test pull-tekton-pipeline-unit-tests

tekton-robot · 2023-11-02T20:36:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

tekton-robot · 2023-11-02T20:37:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

tekton-robot · 2023-11-02T20:41:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

pkg/reconciler/taskrun/resources/taskspec.go

JeromeJu · 2023-11-02T20:53:40Z

pkg/reconciler/taskrun/resources/taskspec.go

 	steps := []v1.Step{}
 	for _, step := range taskSpec.Steps {
 		s := step.DeepCopy()
 		if step.Ref != nil {
 			s.Ref = nil
+			getStepAction := GetStepActionFunc(tekton, tr.Namespace)


Could you help me to understand the reason this needs to be in the loop?

The follow up PR needs to have it in the loop to get the step.Ref.Resolver
#7321

QuanZhang-William · 2023-11-02T21:01:05Z

/lgtm

tekton-robot · 2023-11-02T21:04:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

tekton-robot · 2023-11-02T21:05:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

pkg/reconciler/taskrun/taskrun.go

This commit moves extractStepActions to a dedicated function called in Taskrun Reconciler, this can help the work for remote resolution of StepAction and also decouple the functions. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

tekton-robot · 2023-11-02T21:31:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

tekton-robot · 2023-11-02T21:33:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

jerop · 2023-11-03T12:02:48Z

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look 🙏🏾

chitrangpatel · 2023-11-03T12:09:45Z

/approve

tekton-robot · 2023-11-03T12:09:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chitrangpatel,jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop

/lgtm

jerop · 2023-11-03T14:31:05Z

/retest

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels Nov 2, 2023

tekton-robot requested review from afrittoli and jerop November 2, 2023 20:26

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2023

Yongxuanzhang force-pushed the refactor-extractStepActions branch from 8b4a7d7 to d9ec3c7 Compare November 2, 2023 20:29

Yongxuanzhang marked this pull request as ready for review November 2, 2023 20:34

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023

tekton-robot requested review from bobcatfish and vdemeester November 2, 2023 20:34

Yongxuanzhang assigned chitrangpatel and jerop Nov 2, 2023

JeromeJu reviewed Nov 2, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/taskspec.go Outdated Show resolved Hide resolved

JeromeJu reviewed Nov 2, 2023

View reviewed changes

Yongxuanzhang force-pushed the refactor-extractStepActions branch from d9ec3c7 to 9336465 Compare November 2, 2023 20:57

Yongxuanzhang requested a review from JeromeJu November 2, 2023 20:58

tekton-robot assigned QuanZhang-William Nov 2, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023

jerop reviewed Nov 2, 2023

View reviewed changes

pkg/reconciler/taskrun/taskrun.go Outdated Show resolved Hide resolved

pkg/reconciler/taskrun/taskrun.go Outdated Show resolved Hide resolved

pkg/reconciler/taskrun/taskrun.go Outdated Show resolved Hide resolved

[TEP-0142] Refactor extractStepActions

3d63cf7

This commit moves extractStepActions to a dedicated function called in Taskrun Reconciler, this can help the work for remote resolution of StepAction and also decouple the functions. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Yongxuanzhang force-pushed the refactor-extractStepActions branch from 9336465 to 3d63cf7 Compare November 2, 2023 21:24

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023

Yongxuanzhang mentioned this pull request Nov 2, 2023

TEP-0142: Enable Step Reusability - Implementation #7259

Closed

20 tasks

jerop approved these changes Nov 3, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023

jerop reviewed Nov 3, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023

jerop mentioned this pull request Nov 3, 2023

Flake: entrypoint test TestRealWaiterWaitWithContent #5254

Open

tekton-robot merged commit a791d49 into tektoncd:main Nov 3, 2023
12 checks passed

jerop added this to the Pipelines v0.54 milestone Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEP-0142] Refactor extractStepActions #7328

[TEP-0142] Refactor extractStepActions #7328

Yongxuanzhang commented Nov 2, 2023 •

edited

Loading

tekton-robot commented Nov 2, 2023

Yongxuanzhang commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

JeromeJu Nov 2, 2023

Yongxuanzhang Nov 2, 2023

QuanZhang-William commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

jerop commented Nov 3, 2023 •

edited

Loading

chitrangpatel commented Nov 3, 2023

tekton-robot commented Nov 3, 2023

jerop left a comment

jerop commented Nov 3, 2023

[TEP-0142] Refactor extractStepActions #7328

[TEP-0142] Refactor extractStepActions #7328

Conversation

Yongxuanzhang commented Nov 2, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Nov 2, 2023

Yongxuanzhang commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

JeromeJu Nov 2, 2023

Choose a reason for hiding this comment

Yongxuanzhang Nov 2, 2023

Choose a reason for hiding this comment

QuanZhang-William commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

jerop commented Nov 3, 2023 • edited Loading

chitrangpatel commented Nov 3, 2023

tekton-robot commented Nov 3, 2023

jerop left a comment

Choose a reason for hiding this comment

jerop commented Nov 3, 2023

Yongxuanzhang commented Nov 2, 2023 •

edited

Loading

jerop commented Nov 3, 2023 •

edited

Loading