Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap nop final step with entrypoint #748

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Wrap nop final step with entrypoint #748

merged 1 commit into from
Apr 10, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Apr 10, 2019 •
edited
Loading

Changes

nop image/step used to be executed only when all the previous step
were done sucessfully. As we are not using init containers anymore,
this is not true, nop will always be executed even in case of
previous failure (after the others though). This happens because we
don't use the entrypoint wrapper for this final step.

This fixes it by wrapping nop with entrypoint — just like other
steps. That way, it will only print build successful in case of
actual successful run dancer

Related is #715, but in the meantime, we may want to print something less misleading we may want to fix that 👼

cc @nader-ziada

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 10, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2019
chmouel
chmouel reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds informative!

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2019
@nader-ziada
Copy link
Member

You already mention the other PR to remove the nop image as its not really needed anymore now that already have containers, (#715)
feels like we should get the other one merged in, or remove the nop here if there are other issues with the other PR

@vdemeester
Copy link
Member Author

You already mention the other PR to remove the nop image as its not really needed anymore now that already have containers, (#715)
feels like we should get the other one merged in, or remove the nop here if there are other issues with the other PR

@nader-ziada Right, the only thing is that #715 is on hold, quoting @dicarlo2

This image might actually be useful long-term for managing sidecars - working on a small PoC to show how. (The tests failed anyways, but just in case someone retests and they pass)

While waiting we may want to fix the wording 👼 That said I'm also ok closing this one and waiting for a resolution on #715 😉

@vdemeester
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2019
@vdemeester
Wrap nop final step with entrypoint
1ea0766 
`nop` image/step used to be executed *only* when all the previous step
were done sucessfully. As we are not using init containers anymore,
this is not true, `nop` will always be executed even in case of
previous failure (after the others though). This happens because we
don't use the `entrypoint` wrapper for this final step.

This fixes it by wrapping `nop` with entrypoint — just like other
steps. That way, it will only print `build successful` in case of
actual successful run 💃

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester changed the title Print Build finished instead of sucessful in nop Wrap nop final step with entrypoint Apr 10, 2019
@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2019
@nader-ziada
Copy link
Member

nice fix @vdemeester 👏

@nader-ziada
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@tekton-robot tekton-robot merged commit 40c9b4a into tektoncd:master Apr 10, 2019
@vdemeester vdemeester deleted the nop-finished branch April 10, 2019 18:26
@dwnusbaum dwnusbaum mentioned this pull request Apr 11, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmouel chmouel chmouel left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@nader-ziada nader-ziada

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vdemeester @tekton-robot @nader-ziada @chmouel @googlebot