-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable minimal embedded status is alpha integration tests #1096
Conversation
In tektoncd/pipeline#5032, we added the logic for setting embedded status when running end to end tests. In this change, we set `embedded-status` to `"minimal"` so that we can dogfood the feature alongside other alpha features. This also allows us to run examples with `Matrix` which needs minimal embedded status.
/kind misc |
/test check-pr-has-kind-label |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
In tektoncd/pipeline#5032, we added the logic for setting embedded status when running end to end tests.
In this change, we set
embedded-status
to"minimal"
so that we can dogfood the feature alongside other alpha features. This also allows us to run examples withMatrix
which needs minimal embedded status.As discussed in slack thread: https://tektoncd.slack.com/archives/CJ4ERJWAU/p1655990546574359
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.