-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract release notes from PRs into release notes #509
Conversation
/kind feature |
We still need to manually write update and deprecation notes and backward incompatible changes, but at least release notes are in. This is an example of a fully automated, untouched generated release note: https://gist.github.com/afrittoli/fd374fc87d07cb2722916d30968f6525 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this fixes #504 also :D 🎉
Indeed, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
/lgtm
/test plumbing-yamllint |
Add the ability to extract release notes from the PRs into the generated release notes. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
9edf6cb
to
c0d9d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test plumbing-golang-lint |
Changes
Add the ability to extract release notes from the PRs into the
generated release notes.
Fixes: #504
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.