Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract release notes from PRs into release notes #509

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Aug 12, 2020

Changes

Add the ability to extract release notes from the PRs into the
generated release notes.

Fixes: #504

Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@afrittoli
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2020
@afrittoli
Copy link
Member Author

/cc @bobcatfish @sbwsg @vdemeester

@tekton-robot tekton-robot requested review from a user and vdemeester August 12, 2020 14:39
@afrittoli
Copy link
Member Author

afrittoli commented Aug 12, 2020

We still need to manually write update and deprecation notes and backward incompatible changes, but at least release notes are in. This is an example of a fully automated, untouched generated release note:

https://gist.github.com/afrittoli/fd374fc87d07cb2722916d30968f6525

Copy link
Contributor

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this fixes #504 also :D 🎉

@afrittoli
Copy link
Member Author

i think this fixes #504 also :D 🎉

Indeed, thanks!

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉
/lgtm

@afrittoli
Copy link
Member Author

/test plumbing-yamllint

Add the ability to extract release notes from the PRs into the
generated release notes.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@afrittoli
Copy link
Member Author

/test plumbing-golang-lint

@tekton-robot tekton-robot merged commit cd7a02f into tektoncd:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update create-draft-release to pull in release notes
4 participants