Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Create test helpers for downstream projects to use #10

Closed
ghost opened this issue Mar 8, 2022 · 1 comment
Closed

Create test helpers for downstream projects to use #10

ghost opened this issue Mar 8, 2022 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ghost
Copy link

ghost commented Mar 8, 2022

Feature request

Add a set of test helpers to resolution that projects like Pipelines can use to easily stub / mock ResourceRequest objects, Requester and ResolvedResource implementations, and errors.

Use case

Currently Pipelines maintains its own set of test helpers for stubbing resolution types and also code for mocking the base64 encoded response to a ResourceRequest object: https://github.com/sbwsg/pipeline/blob/pipelineref-remote-res/pkg%2Freconciler%2Fpipelinerun%2Fpipelinerun_test.go#L8770-L8791

It would be great if Pipelines did not have to host this code and instead this kind of test support was available from resolution test helpers. Once these helpers are written Pipelines should be updated to use them.

@ghost ghost added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2022
@abayer
Copy link
Contributor

abayer commented Jun 1, 2022

Oops, fixed this in #51 but forgot to call it out.

@abayer abayer closed this as completed Jun 1, 2022
@abayer abayer self-assigned this Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant