Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkn-results CLI flags are broken, unknown flag error #567

Closed
avinal opened this issue Aug 21, 2023 · 2 comments · Fixed by #568
Closed

tkn-results CLI flags are broken, unknown flag error #567

avinal opened this issue Aug 21, 2023 · 2 comments · Fixed by #568
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@avinal
Copy link
Member

avinal commented Aug 21, 2023

Expected Behavior

tkn-results should not show errors for existing flags

Actual Behavior

tkn-results shows unknown flag error

image

Steps to Reproduce the Problem

  1. Checkout the latest main branch 3e249c3
  2. Build tkn-results
  3. Configure tkn-results config
  4. Run a command with flags tkn-results list default --filter="summary.type=TASK_RUN"

Additional Info

  • Kubernetes version:

    Output of kubectl version:

      clientVersion:
        buildDate: "2023-07-19T12:20:54Z"
        compiler: gc
        gitCommit: fa3d7990104d7c1f16943a67f11b154b71f6a132
        gitTreeState: clean
        gitVersion: v1.27.4
        goVersion: go1.20.6
        major: "1"
        minor: "27"
        platform: linux/amd64
      kustomizeVersion: v5.0.1
      serverVersion:
        buildDate: "2022-10-25T19:35:11Z"
        compiler: gc
        gitCommit: 434bfd82814af038ad94d62ebe59b133fcb50506
        gitTreeState: clean
        gitVersion: v1.25.3
        goVersion: go1.19.2
        major: "1"
        minor: "25"
        platform: linux/amd64
  • Tekton Pipeline version: v0.47.2

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Additional Info

Likely caused by #461

@avinal avinal added the kind/bug Categorizes issue or PR as related to a bug. label Aug 21, 2023
@khrm khrm mentioned this issue Aug 21, 2023
8 tasks
@khrm
Copy link
Contributor

khrm commented Aug 21, 2023

/assign @khrm

@khrm khrm added this to the v0.8.0 milestone Aug 21, 2023
@khrm
Copy link
Contributor

khrm commented Aug 22, 2023

I have added this to v0.8.0 milestone. Need the fix to be merged before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants