Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a skeleton controller that does nothing #8

Closed
bobcatfish opened this issue Jun 23, 2019 · 2 comments
Closed

Create a skeleton controller that does nothing #8

bobcatfish opened this issue Jun 23, 2019 · 2 comments
Assignees
Milestone

Comments

@bobcatfish
Copy link
Collaborator

bobcatfish commented Jun 23, 2019

It will be easier for ppl to start adding functionality if we add an empty controller that doesn't actually reconcile anything, just:

  • Has all the config needed to build and deploy with ko
  • Will start running and invoke a reconcile loop of some kind that does nothing (maybe just logs hello world?)

Additional info

Continuing to use knative/pkg is probably our best bet for now, in which case we can get a lot of this by more or less copying https://github.com/tektoncd/pipeline/blob/master/cmd/webhook.

@ncskier
Copy link
Member

ncskier commented Jul 2, 2019

/assign @ncskier

@ncskier
Copy link
Member

ncskier commented Jul 22, 2019

PR #18 completes this issue.

@ncskier ncskier closed this as completed Jul 22, 2019
@bobcatfish bobcatfish added this to the Triggers 0.1 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants