Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove podTemplate, serviceType field from eventlistener spec #849

Closed
savitaashture opened this issue Dec 2, 2020 · 1 comment
Closed

Remove podTemplate, serviceType field from eventlistener spec #849

savitaashture opened this issue Dec 2, 2020 · 1 comment
Assignees
@savitaashture
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Triggers v0.11

Comments

@savitaashture
Copy link
Contributor

savitaashture commented Dec 2, 2020 •
edited
Loading

podTemplate, serviceType has been deprecated as part of 0.10 release and it will be removed in 0.11
podTemplate, serviceType now handled as part of spec.Resources.KubernetesResource

As of now we will not remove serviceAccountName for the ease of usage

/kind cleanup
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 2, 2020
@khrm khrm added this to the Triggers v0.11 milestone Dec 2, 2020
@savitaashture savitaashture changed the title Remove podTemplate, serviceType and serviceAccountName field from eventlistener spec Remove podTemplate, serviceType field from eventlistener spec Dec 3, 2020
@savitaashture savitaashture mentioned this issue Dec 3, 2020
Merged
4 tasks
@savitaashture
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savitaashture savitaashture

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
Triggers v0.11
Development

No branches or pull requests
3 participants
@khrm @savitaashture @tekton-robot