Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate PR 574 #577

Closed
wants to merge 6 commits into from
Closed

Validate PR 574 #577

wants to merge 6 commits into from

Conversation

mapedraza
Copy link
Collaborator

@mapedraza mapedraza commented Jan 21, 2022 •
edited
Loading

Imported changes from PR #574

Added a test that disconnect the DB and check if retrieving data gives error 500

@mapedraza
Copy link
Collaborator Author

Testing the case proposed by PR #574 is not working.

When requesting to the API with the DB disconnected, the following error is given:

(node:30203) [MONGODB DRIVER] Warning: the options [servers] is not supported
(node:30203) [MONGODB DRIVER] Warning: the options [caseTranslate] is not supported
(node:30203) [MONGODB DRIVER] Warning: the options [dbName] is not supported
        1) should return 500

mapedraza
mapedraza commented Jan 21, 2022
View reviewed changes
test/unit/sthDatabase_test.js Outdated
@@ -1205,4 +1264,5 @@ describe('sthDatabase tests', function() {

describe('final clean up', cleanDatabaseTests);
});
/*eslint-enable */
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed

test/unit/sthDatabase_test.js Outdated
@@ -21,7 +21,7 @@
* please contact with: [german.torodelvalle@telefonica.com]
*/

/* eslint-disable consistent-return */
/*eslint-disable */
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be restored

@mapedraza mapedraza mentioned this pull request Jan 21, 2022
Merged
@mapedraza
Copy link
Collaborator Author

In 36f486d
Moved test from test/unit/sthDatabase_test.js to test/unit/sth_test.js

@Gauravp-NEC
Copy link
Contributor

@mapedraza @fgalan , This PR is overpassed by PR :#583

@fgalan
Copy link
Member

fgalan commented Mar 24, 2022

Having merged PR #574 (and PR #583) I think this one could be closed.

@mapedraza
Copy link
Collaborator Author

After merging #583 this PR does not make sense.

@mapedraza mapedraza closed this Mar 24, 2022
@fgalan fgalan deleted the task/validate_PR_574 branch March 24, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapedraza @Gauravp-NEC @fgalan