Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telepresence needs a mechanism for better output #572

Closed
5 of 6 tasks
ark3 opened this issue Apr 9, 2018 · 2 comments
Closed
5 of 6 tasks

Telepresence needs a mechanism for better output #572

ark3 opened this issue Apr 9, 2018 · 2 comments
Assignees
Labels
t:feature New feature or enhancement request

Comments

@ark3
Copy link
Contributor

ark3 commented Apr 9, 2018

Telepresence doesn't make it clear what's going on at any moment. Better output during startup and shutdown, as well as explicit indications of when those phases start and end, would significantly improve the user experience. Sometimes it's not clear that output is from Telepresence (or its subordinate tools) rather than the user's process. And sometimes it's not clear whether Telepresence's output represents a status update, a fatal error message, or something else. There are many issues that touch on bits and pieces of this.

Let's implement some basic tools for notices, error messages, etc., so that we can address those issues going forward in a consistent way.

Goals

  • Make it clear what output is from Telepresence (Testable output #701)
  • Make it clear what's startup, when stuff is running, and when shutdown is happening
  • Make error messages clearly as errors (e.g., "'ip addr' nor 'ifconfig' available" is unclear)
  • One spot for isatty() stuff, deciding whether we're interactive, controlling verbosity (Testable various #720)
  • No more print() in the code other than this tooling (Testable output #701)
  • Make it easy to refer to documentation and issues

Non-goals (file other issues for these)

  • New or better error handling
  • Different control flow/UX
@ark3 ark3 added the t:feature New feature or enhancement request label Apr 9, 2018
@ark3 ark3 added this to Output in Blobs Apr 9, 2018
@ark3
Copy link
Contributor Author

ark3 commented Apr 9, 2018

See also the Output column of the Blobs project.

@ark3 ark3 self-assigned this Apr 20, 2018
@ark3 ark3 mentioned this issue Jul 9, 2018
ark3 pushed a commit that referenced this issue Jul 9, 2018
Make output to the user go through the runner instead of using print.
In service of #628 and #572.
@ark3 ark3 mentioned this issue Aug 1, 2018
ark3 pushed a commit that referenced this issue Aug 1, 2018
Make various remaining items testable.
Adds an explicit sudo warning to partly address #262.
Addresses the isatty item from #572.
Fixes #278.
Fixes #306.
In service of #628.
@ark3
Copy link
Contributor Author

ark3 commented Aug 10, 2018

There has been some work to this end in #701, #720, and #732. We should reevaluate the status of this issue.

@ark3 ark3 added this to To do in Tel Tracker via automation Jan 25, 2019
@ark3 ark3 moved this from To do to In progress in Tel Tracker Jan 25, 2019
@ark3 ark3 closed this as completed in #913 Jan 25, 2019
Tel Tracker automation moved this from In progress to Done Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
Blobs
Output
Development

No branches or pull requests

1 participant