Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telepresence package on Fedora includes conntrack but does not look for it in the right place #278

Closed
plombardi89 opened this issue Aug 30, 2017 · 6 comments

Comments

@plombardi89
Copy link
Contributor

@plombardi89 plombardi89 commented Aug 30, 2017

What were you trying to do?

Upgraded Telepresence to 0.65-1 and then ran telepresence --run-shell

What did you expect to happen?

Telepresence would start a shell.

What happened instead?

plombardi@palwork ~/w/k7t-be> telepresence --run-shell
Please install conntrack
See the documentation at http://telepresence.io for more details.

Expectations

I'm not sure what conntrack is or how to install it. I went to telepresence.io as instructed and the install instructions for Fedora 25 do not indicate I need to do anything differently or install any 3rd party software.

@plombardi89
Copy link
Contributor Author

@plombardi89 plombardi89 commented Aug 30, 2017

So... I went to install conntrack and low and behold I already have it.

plombardi@palwork ~/w/k7t-be> sudo -s dnf install conntrack
Package conntrack-tools-1.4.3-1.fc25.x86_64 is already installed, skipping.
Dependencies resolved.
Nothing to do.
Complete!

So it appears this is a bug in Telepresence.

@rhs
Copy link
Contributor

@rhs rhs commented Aug 30, 2017

FWIW, this worked for me on fedora 25 with exactly the same version of conntrack-tools that you have.

@rhs
Copy link
Contributor

@rhs rhs commented Aug 30, 2017

For the record, @plombardi89 and I did a little out of band environment comparisons. It looks like the critical difference in this case is that /usr/sbin is in my path, but it is not in @plombardi89's path, and this is where conntrack lives.

A possible fix for this would be for telepresence to append /usr/sbin to the path that it uses to search for conntrack. This would allow users to override paths if they wanted a specific conntrack to be used, but would not break if /usr/sbin is not in the users path.

@ark3 ark3 self-assigned this Aug 30, 2017
@ark3 ark3 added the t:feature label Aug 30, 2017
@ark3
Copy link
Contributor

@ark3 ark3 commented Aug 31, 2017

I added a bit more clarity in 2670fbf. Now Telepresence will tell you something like

(Ran "which conntrack" to check in your $PATH.)

if that check fails. Checking extra locations is also an option, but I think the main problem here was that Telepresence did not report what it was really trying to do that failed. What do you think @plombardi89 @rhs?

@ark3 ark3 added the question label Aug 31, 2017
@itamarst
Copy link
Contributor

@itamarst itamarst commented Sep 3, 2017

  1. Telepresence needs conntrack on newer Fedora. If it's not available, e.g. because /usr/sbin isn't in $PATH, by default, that's a bug.
  2. Given Telepresence is packaged for Fedora specifically, it's a supported platform, it's legit and desirable to add /usr/sbin to $PATH so it works on Fedora.
  3. The checks for existence are mainly a debugging use case at this point, given we have packaging (originally people needed to install stuff manually). That is, a failure indicates either a bug in Telepresence or a really messed up environment. In this case it's the former. So one could argue that any of these warnings should automatically come with a "please file a bug" prompt.
@ark3 ark3 added this to Next in Telepresence Sep 6, 2017
@plombardi89 plombardi89 added this to UX in Roadmap Feb 21, 2018
@plombardi89 plombardi89 moved this from UX to Bugs in Roadmap Feb 21, 2018
@richarddli richarddli added this to Robustness in T Roadmap (v2) Feb 21, 2018
@rhs rhs added this to Enhancement in Buckets Mar 8, 2018
@plombardi89
Copy link
Contributor Author

@plombardi89 plombardi89 commented Mar 23, 2018

Just hit this again :(

@ark3 ark3 changed the title Telepresence tells me to install conntrack but isn't very helpful Telepresence package on Fedora includes conntrack but does not look for it in the right place Mar 23, 2018
@ark3 ark3 removed their assignment Mar 28, 2018
@ark3 ark3 mentioned this issue Aug 1, 2018
@ark3 ark3 closed this in #720 Aug 1, 2018
Roadmap automation moved this from Bugs to Completed Aug 1, 2018
ark3 added a commit that referenced this issue Aug 1, 2018
Make various remaining items testable.
Adds an explicit sudo warning to partly address #262.
Addresses the isatty item from #572.
Fixes #278.
Fixes #306.
In service of #628.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Roadmap
  
Completed
T Roadmap (v2)
Robustness
Buckets
Enhancement
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants