Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the "landscape" mode have a big problem #8

Closed
bau720123 opened this issue Nov 1, 2014 · 23 comments
Closed

the "landscape" mode have a big problem #8

bau720123 opened this issue Nov 1, 2014 · 23 comments

Comments

@bau720123
Copy link

according to this
http://plugins.telerik.com/plugin/native-page-transitions

all animation in "portrait" mode no problem at all
but when in "landscape" mode,it will become so starnge (no mater any direction or what kind of animation type)
such like these screenshot
http://www.littlebau.com/20141101/02drawer.PNG
http://www.littlebau.com/20141101/03drawer.PNG

PS
above situation that only happen in iOS

@bau720123
Copy link
Author

hi @EddyVerbruggen or somebody
is there anything update or ?

@bau720123
Copy link
Author

hi @EddyVerbruggen
just made a note...
for now I am using latest 0.2.1 version
https://build.phonegap.com/plugins/1267
but the problem still exist

@Ldaco
Copy link

Ldaco commented Nov 25, 2014

I'm also experiencing some odd behavior when using in landscape mode that makes it unusable in that layout. I've attached what it looks like when it starts and then what it looks like after the slide has completed.

initial page
after slide

I am also running version 0.2.1 of the plugin. iOS is at 8.1.1 on an iPad 2

@EddyVerbruggen
Copy link
Contributor

Thanks! I'll pick this up any day now.

@EddyVerbruggen
Copy link
Contributor

@Ldaco, I have an iPad 2 and v0.2.1 of the plugin. I also have an (Ionic) app with a slide transition.

The thing is, my app behaves correctly, so it may be something in your .plist. Is it possible to share your project with me? Perhaps a stripped version, as long as it shows off the problem. That would be incredibly helpful.

@Ldaco
Copy link

Ldaco commented Dec 1, 2014

The same behavior appears in the demo app if you enable that for landscape. I went into project properties and enabled it to rotate to landscape. I then started the demo application and it starts out ok, but then when I click on Steven the slide happens and I'm left with a lot of "black" area. Clicking the back button does do a slide back, but again, it's a bunch of "black" area and the canvas of the application has changed.

initial load

clicked steven

clicked back

I can send you the zip of the demo project, but I'm guessing you don't need it to replicate the same thing? Let me know if you do want the specific zip and I'll upload it somewhere, but again, I haven't actually changed anything in that project aside from the orientation modes supported.

My iPad model is A1458 (4th Generation)

I did also update my project to version 0.2.2. of your plugin, but from the comments it looked like it was just another adapter, but still, I've got that updated and checked in to my code as well.

Thank you!

@EddyVerbruggen
Copy link
Contributor

@Ldaco actually, sending me your demo app would help. You can drop it at eddyverbruggen at gmail dot com and I'll get on it asap.

@mjoakim
Copy link

mjoakim commented Dec 5, 2014

I have the exact same problem, unfortunately. It's preventing me from finishing the app. My friends just notified me about it, and I confirmed it on my iPhone 4 with iOS 7.1.2. For me, it happens when I rotate the screen at the same time as I do a slide transition.. I already tried making my app lock the screen when doing transitions, but it's still possible for the user to start the transition and concurrently rotate the screen. I also tried to make the app delay its transition for 800 ms, when it detected a screen rotation.

Update: The issue here is the exact same as mentioned above. I just only noticed it, when I rotated the phone. But as mentioned, it only happens in landscape mode. Which means that this plugin is unusable for now, unfortunately.

@Ldaco
Copy link

Ldaco commented Dec 5, 2014

Well, it's usable if you lock your application into portrait mode. That's what we've done for now as that tends to make sense for us anyways. It would be great to hear that the landscape portion works some day though!

@mjoakim
Copy link

mjoakim commented Dec 5, 2014

@Ldaco How about locking an iPad application into landscape mode? Did you try that? I didn't try it yet, but I'm thinking that it won't work. Anyway, sounds like a fix should be right around the corner.

@Ldaco
Copy link

Ldaco commented Dec 5, 2014

@mjoakim I have NOT tested it locked down to landscape, but I'll give that a shot later today just to see what it does with the demo app and will report what I see on here.

@mjoakim
Copy link

mjoakim commented Dec 5, 2014

@Ldaco Actually, I did the landscape lock-down test on an iPhone, but the issue was still present. I just didn't try it on an iPad. Now, what I'm thinking here is that landscape mode is the natural 0 degrees mode for tablets, and portrait is 0 degrees for phones, so maybe that could have an influence here..? Without really knowing any more technical details. Eddy would be the one to ask here.

EddyVerbruggen added a commit that referenced this issue Dec 5, 2014
@EddyVerbruggen
Copy link
Contributor

Hi guys, I've been working on iOS landscape support today and I'm happy to announce version 0.2.3 (EDIT: 0.2.5) of this plugin seems to no longer have issues when rotated to landscape.

Please confirm, so we can close this issue.

Thanks for all your reports and testing efforts!
Eddy

@mjoakim
Copy link

mjoakim commented Dec 7, 2014

Thank you very much! It seems to work perfectly so far :) I've stress-tested it a bit, turning the phone several times while changing page in the app. No issues so far.

@bau720123
Copy link
Author

hi @EddyVerbruggen
just made a note
the latest version 0.2.2 still have this problem in PGB
https://build.phonegap.com/plugins/1309
I will wait your new version 0.2.3 until new release

PS
according to this
http://phonegap.com/blog/2014/12/09/phonegap-build-new-features/
"Plugins no longer must be reviewed and approved"
Congratulation~

@mjoakim
Copy link

mjoakim commented Dec 11, 2014

@EddyVerbruggen I think you might need to submit your updated plugin(s) again to PGB, because even though they dropped the review/approval process, it doesn't seem like they put your new version(s) on there.

By the way, as an alternative, is it possible to make your plugin available on plugins.cordova.io ?

@EddyVerbruggen
Copy link
Contributor

They seem to have forgotten to approve plugins pending in review. And now they don't allow you to upload plugins from a free account (which I have). 👎

@mjoakim
Copy link

mjoakim commented Dec 11, 2014

Well, if your plugin can be uploaded to plugins.cordova.io , it wouldn't matter anyway, as Adobe lets people use that now.

@EddyVerbruggen
Copy link
Contributor

Yes I know. But I feel like that's being forced down my throat before anything else.

@mjoakim
Copy link

mjoakim commented Dec 12, 2014

Yea, there's always some business plan behind these decisions and changes, even though it might not be obvious at first. Anyway, I'm just curious - does plugins.cordova.io work a lot differently than PGB plugins in terms of structuring of the repository?

@EddyVerbruggen
Copy link
Contributor

Hi @mjoakim, the structure is the same. There are a few things in plugin.xml you need to set correctly, but it's an easy task. The additional step is you need to publish it via the plugman CLI, but that's not harder than the phonegap build process was.

Anyway, you can now do:

<gap:plugin name="com.telerik.plugins.nativepagetransitions" source="plugins.cordova.io" />

to always get the latest version.

@mjoakim
Copy link

mjoakim commented Dec 19, 2014

Thank you very much :)

@bau720123
Copy link
Author

thanks @EddyVerbruggen
problem solved in 0.2.7 by plugins.cordova.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants