Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR resource is not getting picked after adding a label . #243

Open
Plavhate-ford opened this issue Dec 2, 2020 · 3 comments
Open

PR resource is not getting picked after adding a label . #243

Plavhate-ford opened this issue Dec 2, 2020 · 3 comments

Comments

@Plavhate-ford
Copy link

I have my pipeline which refreshes the PR list after every 5sec. Also, it uses the GitHub label "LGTM" to filter the PRs. Now I have PR #1 without the "LGTM" tag. And PR #2 generated after PR1, with LGTM tag.
After the pipeline is refreshed and PR2 is picked by concourse, I added the label "LGTM" to PR#1.
But now the pipeline is not showing PR#1.

  • name: my_pr
    type: github-pr
    source:
    repository: *********
    access_token: ((token))
    labels: ["LGTM"]
    check_every: 5m
@Plavhate-ford
Copy link
Author

This has been blocking us, can anyone help on this?

@jhosteny
Copy link
Contributor

This sounds similar to #189. I'm not sure if that would also fix the issue with labels, but I think it might?. We are currently running a version of the resource with #189 merged into it until it is that fix is merged upstream, to avoid similar PR issues with out of order commits.

@bgandon
Copy link

bgandon commented May 11, 2024

This is related to #26.

Unfortunately, there's no hope that you get any further support here (#246 was 2+y ago).

But recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

Turns out a fix for #26 has been shipped in the latest release of Cloud Foundry community fork.

On our Concourse installation at Gstack, that one is working fine. Could you give a try and provide feedback there?

(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants