Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Allow searching for account name/address alias #48

Closed
donnyquixotic opened this issue Mar 8, 2022 · 1 comment
Closed
Assignees
Labels
✨ Enhancement Improvements on existing features

Comments

@donnyquixotic
Copy link
Contributor

donnyquixotic commented Mar 8, 2022

Overview

Presently, users can only search for specific addresses in the search bar. Usability would be improved if users could search by account name/alias, eg. typing in CharmDojo would allow the user to go to /address/0x730d2fa7dc7642e041bce231e85b39e9bf4a6a64

Acceptance criteria

  • when typing in a non-address string into the search bar, a dropdown/card should appear prompting the user to go to the address page matching the query
    • clicking the dropdown/card should bring the user to the address page
    • by default, pressing enter (as opposed to clicking the new UI element) should first attempt to use the search query as an address;
  • a minimum of 3 character should trigger the alias UI element
  • multiple results will need to be handled, eg. if the user types TLO, at least 2 results will match--Wrapped TLOS and sTLOS
    • there should be a maximum number of matches to prevent vertical overflow, or follow etherscan pattern of creating a scrollable container with a max height
  • new UI element should be keyboard navigable; tab/shift+tab and arrow up/arrow down should allow the user to select the new UI element, and enter/space should go to the selected element; esc should hide the result(s)
  • the dropdown menu should indicate tokens vs addresses vs contracts

Technical considerations

  • it may be that the [currently in progress] indexer is required to do this mapping on the fly. See TransferTable.vue or AccountAddress.vue to determine if existing logic can be reused to this end

  • refer to etherscan for their handling of this pattern for inspiration

  • though WTLOS is used as an example, actual /token route is not yet implemented, and as such are out of scope here. navigating to WTLOS should go to the address/ route for now, with token route implementation being added in Add ability for users to get to /token from search #83

Tasks

@donnyquixotic donnyquixotic added the ✨ Enhancement Improvements on existing features label Mar 8, 2022
@ezra-sg ezra-sg added 🔬 Needs Refinement Further information is required and removed 🔬 Needs Refinement Further information is required labels Oct 9, 2022
@tomtomcrypto tomtomcrypto self-assigned this Feb 20, 2024
@pmjanus pmjanus closed this as completed Jul 26, 2024
@pmjanus pmjanus closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
@pmjanus
Copy link
Contributor

pmjanus commented Jul 26, 2024

This is being handled in #800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Improvements on existing features
Projects
None yet
Development

No branches or pull requests

4 participants