Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a 'simple' option #3

Closed
brendo opened this issue Nov 17, 2017 · 0 comments
Closed

Allow for a 'simple' option #3

brendo opened this issue Nov 17, 2017 · 0 comments
Assignees

Comments

@brendo
Copy link
Contributor

brendo commented Nov 17, 2017

This plugin currently pulls in mermaid.cli, which brings in puppeteer, which installs in Chromium. This doesn't play nice in docker image which is based on Alpine.

The abstraction in mermaid.cli doesn't allow puppeteer's runtime settings to be altered, so while getting Chromium into the image is likely possible, we'd have no way to tell mermaid so that it can invoke puppeteer correctly.

Instead. Can we offer a simple mode in this plugin that simply takes:

```mermaid
graph LR
    Start --> Stop

And transforms it to be:

<div class='mermaid'>
graph LR
    Start --> Stop
</div>

This will rely on whatever is "generating the markdown" to ensure the mermaid JS file is available so that the graph can be generated client side, but it at least means that authors can start using the syntax now and the solution can be improved later.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant