Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error #3

Open
myhuInShangHai opened this issue May 29, 2018 · 2 comments
Open

error #3

myhuInShangHai opened this issue May 29, 2018 · 2 comments

Comments

@myhuInShangHai
Copy link

image

@paoloposadas
Copy link

Hello! We have confirmed with our engineers that the below .gclient file is needed:

solutions = [ { "managed": False, "name": "src", "url": "https://chromium.googlesource.com/chromium/src.git", "custom_deps": {}, "deps_file": ".DEPS.git", "safesync_url": "", }, ]

And after doing so, do a gclient sync

gclient sync

Kindly see the below for your references:
https://stackoverflow.com/questions/8684282/gclient-runhooks-fails
https://www.chromium.org/developers/how-tos/depottools

@agouaillard-cosmo
Copy link

This is a project that did not receive any new commit for 4 years and should be considered dead.

That being said, here are some informations:

  • as written in the README " It is based on the peerconnection_client that is provided in the reference code." this depends on you checking out the webrtc.org code first, and then adding this code in the /talk/ directory.
  • Note that the /talk/ directory doe snot exist in the webrtc code since more than 4 years (https://chromium.googlesource.com/external/webrtc/stable/talk/)
  • Note that the project is still using GYP files for configurations, that have been replaced by GN files two years ago in the webrtc code.

oh, and .... you pointed to the CHROMIUM url, and not the webrtc url, so your proposed solution would not work either.

In a normal webrtc checkout, the "fetch" command creates your configuration file, pointing to webrtc URL. You can check in the depot_tools source code for the fetch command:

@staticmethod
def fetch_spec(props):
url = 'https://webrtc.googlesource.com/src.git'
spec = {
'solutions': [
{
'name': 'src',
'url': url,
'deps_file': 'DEPS',
'managed': False,
'custom_deps': {},
},
],
'with_branch_heads': True,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants