-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supplied refs are not propagating to the element #24
Comments
@goyney Can you have them just npm install the master branch and let me know if it works. I'll do a release with this fix if it's all good. |
Fixed this to work with TypeScript. Oversight on the props validation. Let me know this works and I'll push Unit testing isn't possible at this time with Enzyme for refs. I put a placeholder. |
@goyney Were they able to test this? |
Yep, the changes made are good. Feel free to close this upon publish to NPM. :) |
Published! |
Supplying a
ref
to the<Icon>
element does not work properly, likely because refs need to be forwarded in a way different from all other props.(Issue likely affects
<Stack>
s as well.)See: https://reactjs.org/docs/forwarding-refs.html
The text was updated successfully, but these errors were encountered: