Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplied refs are not propagating to the element #24

Closed
mririgoyen opened this issue Jun 18, 2019 · 5 comments
Closed

Supplied refs are not propagating to the element #24

mririgoyen opened this issue Jun 18, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@mririgoyen
Copy link

mririgoyen commented Jun 18, 2019

Supplying a ref to the <Icon> element does not work properly, likely because refs need to be forwarded in a way different from all other props.

(Issue likely affects <Stack>s as well.)

See: https://reactjs.org/docs/forwarding-refs.html

Templarian added a commit that referenced this issue Jun 20, 2019
@Templarian
Copy link
Owner

@goyney Can you have them just npm install the master branch and let me know if it works. I'll do a release with this fix if it's all good.

@Templarian Templarian added the enhancement New feature or request label Jun 20, 2019
@Templarian
Copy link
Owner

Fixed this to work with TypeScript. Oversight on the props validation. Let me know this works and I'll push 1.2.0.

Unit testing isn't possible at this time with Enzyme for refs. I put a placeholder.

@Templarian
Copy link
Owner

@goyney Were they able to test this?

@mririgoyen
Copy link
Author

Yep, the changes made are good. Feel free to close this upon publish to NPM. :)

@Templarian
Copy link
Owner

Published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants