Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add codec HTTP server to the encryptedpayloads sample #491

Open
cretz opened this issue Jun 27, 2023 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jun 27, 2023

Describe the solution you'd like

Add a codec server for use by the UI to the encryptedpayloads sample. See the Go, TypeScript, Python, and .NET samples for inspiration.

@cretz cretz added the enhancement New feature or request label Jun 27, 2023
@lorensr
Copy link
Contributor

lorensr commented Aug 4, 2023

@cretz
Copy link
Member Author

cretz commented Aug 4, 2023

Nice. May just need to use it in the sample then.

@lorensr
Copy link
Contributor

lorensr commented Aug 4, 2023

Would be helpful if it verified token against jwks url and had commented out code for checking the email address against an approved list

@cretz
Copy link
Member Author

cretz commented Aug 4, 2023

Would be helpful if it verified token against jwks url and had commented out code for checking the email address against an approved list

👍 I don't remember why Java made this a top-level supported project when no other SDKs did, but that may need to be a customization made there and just leveraged here. In general though, it sounds like if this is something we want from our codec server samples, we should do it in all. (feel free to take over codec samples to make them more cohesive if they are not enough already, or just open other issues to have SDK do it, though unsure of prioritization)

@lorensr
Copy link
Contributor

lorensr commented Aug 5, 2023

I guess JWKS and email is cloud-specific, so maybe two different examples of the HTTP server routes.

@cretz
Copy link
Member Author

cretz commented Aug 7, 2023

I don't think it's cloud specific. Users setup JWKS on open source (https://github.com/temporalio/samples-go/tree/main/serverjwtauth) and extracting email from the JWT, if that's what you mean, may be a general thing depending on what it's extracting out of the claim. This can just be an option on the existing codec server in each sample IMO.

IMO we should do it to all (or none).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants