Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make compilation work on Mac M1. #90

Closed
bergundy opened this issue Apr 12, 2021 · 1 comment
Closed

[Feature Request] Make compilation work on Mac M1. #90

bergundy opened this issue Apr 12, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@bergundy
Copy link
Member

bergundy commented Apr 12, 2021

When compiling the node SDK, I got the following error with an M1 CPU.

npm ERR! error: failed to run custom build command for `temporal-sdk-core v0.1.0 (/Users/bergundy/temporal/sdk-node/packages/worker/native/sdk-core)`
npm ERR!
npm ERR! Caused by:
npm ERR!   process didn't exit successfully: `/Users/bergundy/temporal/sdk-node/packages/worker/native/target/release/build/temporal-sdk-core-de4edef256dc9a6c/build-script-build` (exit code: 1)
npm ERR!   --- stderr
npm ERR!   Error: Custom { kind: Other, error: "failed to invoke protoc (hint: https://docs.rs/prost-build/#sourcing-protoc): Bad CPU type in executable (os error 86)" }

This is easily fixed by installing protobuf with brew install protobuf and exporting PROTOC=$(which protoc) (See tonic docs).
This is of course not critical but it would be nice to be able to have compilation "just work".

@bergundy bergundy added the enhancement New feature or request label Apr 12, 2021
@bergundy bergundy changed the title [Feature Request] FILL_TITLE_HERE [Feature Request] Make compilation work on Mac M1. Apr 12, 2021
@Sushisource
Copy link
Member

Protoc is always required now all the time, closing this since it's just a given you're gonna need it for general temporal dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants