-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set TemporalChangeVersion when workflow version is updated #587
Comments
We need to do backwards compatibility for this one. |
Hi any progress on this one? |
Hi any progress on this? I have added this in Cadence long time ago. You may copy some code from it which can make it easier: uber/cadence-java-client#650 |
Not yet. It's a pretty tricky task to do because of the backward compatibility and the fact that the Version State Machine is one of the trickiest ones already. It's on my radar though and I will prioritize it when I get a chance. |
Hi, is there any update on this? |
I'm also curious, I tried to query the TemporalChangeVersion and nothing showed up in the TemporalUI because I used the JavaSDK to do a patch on the workflow. |
@Quinn-With-Two-Ns is there an alternative workaround you might recommend to discover versions of WF so that users can more easily remove chunks of code with confidence? |
Try this design pattern https://medium.com/@qlong/how-to-overcome-some-maintenance-challenges-of-temporal-cadence-workflow-versioning-f893815dd18d |
Also this sample temporalio/samples-java#664 |
Thanks @longquanzheng and @Quinn-With-Two-Ns for the references! |
Is your feature request related to a problem? Please describe.
This feature is implemented in Go SDK, not in Java.
Describe the solution you'd like
Set TemporalChangeVersion search attribute to the changeid-version when a new one is set on workflow.
This will allow users to use search queries, like shown here: https://community.temporal.io/t/list-of-running-workflows-having-a-specific-version/1731
Describe alternatives you've considered
Don't implement
This is a really needed feature when using workflow versioning. It works in Go SDK already.
The text was updated successfully, but these errors were encountered: