Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] If self parameter is type hinted, it is not properly ignored when deserializing parameters #318

Closed
cretz opened this issue May 17, 2023 · 0 comments · Fixed by #349
Closed

[Bug] If self parameter is type hinted, it is not properly ignored when deserializing parameters #318

cretz opened this issue May 17, 2023 · 0 comments · Fixed by #349
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented May 17, 2023

Describe the bug

async def run(self: Self, arg: ArgType) will not remove self when deserializing types because of

sdk-python/temporalio/common.py

Line 235 in a4224a2

and value.annotation is inspect.Parameter.empty

We need to see if we can be smarter about ignoring self.
@cretz cretz added the bug Something isn't working label May 17, 2023
cretz added a commit to cretz/temporal-sdk-python that referenced this issue Jul 17, 2023
@cretz
Support typing.Self annotation
d61100b 
Fixes temporalio#318
@cretz cretz mentioned this issue Jul 17, 2023
Merged
cretz added a commit that referenced this issue Jul 18, 2023
@cretz
Log and drop signals whose params can't be deserialized (and other er…
b9df212 
…ror handling improvements) (#349)

Fixes #333
Fixes #318
Fixes #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@cretz