Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Signals that can't be deserialized should be dropped/ignored #347

Closed
cretz opened this issue Jul 13, 2023 · 0 comments · Fixed by #349
Closed

[Bug] Signals that can't be deserialized should be dropped/ignored #347

cretz opened this issue Jul 13, 2023 · 0 comments · Fixed by #349
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Jul 13, 2023 •
edited
Loading

Describe the bug

In Go and Java we drop signals whose args can't be deserialized, we should here too. This is likely not considered a backwards incompatible behavior change.
@cretz cretz added the bug Something isn't working label Jul 13, 2023
cretz added a commit to cretz/temporal-sdk-python that referenced this issue Jul 17, 2023
@cretz
Log and drop signals whose params can't be deserialized
f25ffd3 
Fixes temporalio#347
@cretz cretz mentioned this issue Jul 17, 2023
Merged
cretz added a commit that referenced this issue Jul 18, 2023
@cretz
Log and drop signals whose params can't be deserialized (and other er…
b9df212 
…ror handling improvements) (#349)

Fixes #333
Fixes #318
Fixes #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@cretz