Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of Go SDK client.ConnectionOptions.DisableHealthCheck #2597

Closed
cretz opened this issue Mar 10, 2022 · 0 comments · Fixed by #2611
Closed

Remove use of Go SDK client.ConnectionOptions.DisableHealthCheck #2597

cretz opened this issue Mar 10, 2022 · 0 comments · Fixed by #2611
Assignees
@jbreiding
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Mar 10, 2022

Is your feature request related to a problem? Please describe.

The latest of Go SDK is replacing health check with a get-server-info call, which means that eager connectivity is unavoidable. This was discussed with @alexshtin and @yiminc before proceeding w/ the SDK change.

Describe the solution you'd like

Remove the disable health check option in use and do not instantiate a client until it can reach a server (and/or retry as needed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbreiding jbreiding

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing SdkClient injection with SdkClientFactory injection.
2 participants
@cretz @jbreiding