New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] set DisableInitialHostLookup = true to see if that improves cassandra connectivity time in certain scenarios #1715
Closed
mastermanu
wants to merge
20
commits into
temporalio:master
from
mastermanu:draft_disable_initial_host_lookup
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include namespace in API error log for better debugging exp
* If query task is gone, return not found instead of internal server error
* Make sync match wait time configurable, dynamic config key: `matching.syncMatchWaitDuration` * Remove unused MatchingEnableSyncMatch dynamic config since sync match should always be enabled
* Split ServiceErrContextTimeoutCounter metrics into ServiceErrContextTimeoutCounter and ServiceErrContextCancelledCounter * ServiceErrContextCancelledCounter metrics indicates request being cancelled * ServiceErrContextTimeoutCounter metrics indicates timeout
* Properly calculate lower / higher bound when reading each history branch, otherwise history event branch after fork operation can return more data than requested.
Enabling a Reconnection policy will enable better resiliency in the event that Cassandra nodes happen to churn for a given cluster. We have seen situations where nodes churned, and the only way to recover Temporal was by initiating a reboot. This should address this. Validated change in a deployed test environment. This is a low-risk change.
* Do not truncate time.Duration to seconds, if conversion is necessary for math, use nano seconds * Convert core retry function logic to use nil instead of `0 mean infinite`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.