Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Display binary protobuf payloads #1255

Open
lorensr opened this issue Dec 28, 2021 · 2 comments
Open

[Feature Request] Display binary protobuf payloads #1255

lorensr opened this issue Dec 28, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@lorensr
Copy link
Contributor

lorensr commented Dec 28, 2021

Is your feature request related to a problem? Please describe.

You can't currently get the decoded contents of binary/protobuf payloads like you can for json/plain and json/protobuf.

Describe the solution you'd like

When payload.metadata.messageType is present (a namespaced string like "foo.bar.MyMessage", introduced in temporalio/sdk-typescript#430 and I'll be adding it to other SDKs) in a payload with metadata.encoding == "binary/protobuf", then match it against user-provided protos to decode payload.data, wherever payloads are in a response, for instance here:

/api/v1/namespaces/{namespace}/workflows/{execution.workflowId}/executions/{execution.runId}/events

http://localhost:8080/openapi/#/WorkflowService/WorkflowService_GetWorkflowExecutionHistory

image

User-provided protos

I'm not sure what the easiest way is for users to provide ui-server their .proto files, both in dev and prod.

@lorensr lorensr added the enhancement New feature or request label Dec 28, 2021
@lorensr
Copy link
Contributor Author

lorensr commented Dec 30, 2021

^ is assuming that decoding payloads is done server-side. If payload decoding is done in the browser (like if the "string"s in the pictured payload are base64 encoded binary), then I can migrate this issue to the frontend repo. Also, not sure if tctl dc web is relevant.

I think ideally this feature:

  • would work without having to run tctl
  • for prod, is configured (through providing .proto files) once by a single user (and then all viewers of prod UI would see decoded binary protobufs) until protos changed
  • can be configured programmatically, through a build step

@robholland
Copy link
Contributor

Please move this issue to https://github.com/temporalio/ui, it's not a server issue.

@lorensr lorensr transferred this issue from temporalio/ui-server Mar 29, 2023
@lorensr lorensr reopened this Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants