Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Create a terrascan wrapper with argument validation #5

Closed
jason-tyler opened this issue Nov 2, 2017 · 3 comments
Closed

Comments

@jason-tyler
Copy link

Use a wrapper to allow clients to invoke Terrascan with arguments.

Example: https://github.com/jason-tyler/terrascan/tree/feature/main_args

If you agree with this method, create a "feature/main_args" branch and I'll PR a start at this into your repo.

@cesar-rodriguez
Copy link
Contributor

Definitely. I thought of doing this eventually, but didn't had time to get to it. What I like about this is that we can swap out the dependency on python unittest at some point without affecting the way you execute terrascan.

@jason-tyler
Copy link
Author

Good point. I'll submit a PR after you create the 'feature/main_args' branch in your repo.

@cesar-rodriguez
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants