Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace class Aaa with something resembling real-world code #18

Closed
rdeago opened this issue Nov 11, 2022 · 0 comments · Fixed by #23
Closed

Replace class Aaa with something resembling real-world code #18

rdeago opened this issue Nov 11, 2022 · 0 comments · Fixed by #23
Assignees
Labels
area:code [issue/PR] affects project code (excluding tests). breaking [issue/PR] requires / contains breaking changes. enhancement [issue/PR] requests / implements new or improved functionality.
Milestone

Comments

@rdeago
Copy link
Member

rdeago commented Nov 11, 2022

Reference version

2.0.1-preview

Background and motivation

See #17

Proposed enhancement

A possible addition could be a simple Calculator class with methods like Add, Subtract, etc.

Viable places to look at for additions may be articles about unit testing, C# tutorials, etc.

Implementation proposals

Just some quick guidelines:

  • Don't add anything involving UI and/or I/O.
  • Add a dependency to PolyKit.Embedded to test how coverage tools etc. react to it;
  • Only other allowed dependencies (at least for now): Microsoft extensions, Microsoft polyfills (System.Memory etc.), plus our own L.o.U.I.S. as soon as it is released.

Usage examples

n/a (depends upon the actual additions)

Risks

As already pointed out in #17, the removal of class Aaa is a breaking change, but no one is going to complain about it.

Additional information

@ric15ni I'm fine with the same PR closing this issue and #10 together.

@rdeago rdeago added enhancement [issue/PR] requests / implements new or improved functionality. breaking [issue/PR] requires / contains breaking changes. area:code [issue/PR] affects project code (excluding tests). labels Nov 11, 2022
@rdeago rdeago added this to the 2.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:code [issue/PR] affects project code (excluding tests). breaking [issue/PR] requires / contains breaking changes. enhancement [issue/PR] requests / implements new or improved functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants