Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation proposal: use another path for the migrations path example #277

Closed
wertmenschen opened this issue Oct 11, 2017 · 4 comments
Closed

Comments

@wertmenschen
Copy link

wertmenschen commented Oct 11, 2017

I was a little confused by the example proposed for tenant specific migrations (https://laravel-tenancy.com/documentation/implementation/migrations): storage/app/tenancy/migrations. I usually have nothing within the storage path in my repository, but I think the migrations should belong there. So maybe something like database/tenancy/migrations (which is in the repository by default) would be a better and clearer example?

Also I was a little confused by the term "tenant specific" first - does it mean "regarding ONE specific tenant" or "regarding ALL tenants"? I know it's the latter but maybe there is some better way to say it.

@luceos
Copy link
Contributor

luceos commented Oct 12, 2017

I've also considered moving the default location to a folder directly inside of base_path. Your points are valid though. Any suggestion is welcome, feel free to PR.

@S43534
Copy link

S43534 commented Oct 12, 2017

...didn't realize there is a repository for the documentation. Here you go: https://github.com/hyn/laravel-tenancy.com/pull/2 (sorry, I used another account - it's still me :-) )

@luceos luceos closed this as completed Oct 12, 2017
@luceos luceos reopened this Oct 12, 2017
@luceos
Copy link
Contributor

luceos commented Oct 12, 2017

Reopened as a reminder to move the default tenancy location.

@luceos
Copy link
Contributor

luceos commented Jul 19, 2018

database/migrations/tenant is the new location

@luceos luceos closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants